ManageNetworks: False usecase most likely broken since Victoria

[Harald Jensås]

The ManageNetworks parameter was added in change[1], this disables network resources and instead uses data from network_data.yaml directly as output in the network resources.

With change [2] the ManageNetworks feature was overlooked. The 'network_attrs' and 'subnet_attrs' output of networks will be all 'null' values when ManageNetworks == False. This will result in all null values in the per-role GroupVars.

[1] https://opendev.org/openstack/tripleo-heat-templates/commit/aade43dd12498a54fba34e056342ed480ae9c5f7
[2] https://opendev.org/openstack/tripleo-heat-templates/commit/5b3878580a9768be7c7c39d3062f567eb5e13767

[Harald Jensås (harald-jensas)]

proposed fix: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781572

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/781572
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/80b226c44ce55506460a4914e2d7f2e2de1b41e8
Submitter: "Zuul (22348)"
Branch: master

commit 80b226c44ce55506460a4914e2d7f2e2de1b41e8
Author: Harald Jensås <email address hidden>
Date: Thu Mar 18 22:29:59 2021 +0100

    Fix "ManageNetworks" use-case

    With change I603521bd00dc100e03c765c25503b5e01f3383e4
    the ManageNetworks == False use case was overlooked.

    When ManageNetworks is set to False and networks are
    not created we need to build network_attrs and
    subnet_attrs from the data present in network_data.yaml
    and parameters.

    Closes-Bug: #1920050
    Change-Id: I98a3d582add0d6881cd39433ddb25515f0e0dc31

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 14.1.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/792163
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/d39526de13d0603c92b2e0dd2c0ff6a42257301f
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit d39526de13d0603c92b2e0dd2c0ff6a42257301f
Author: Harald Jensås <email address hidden>
Date: Thu Mar 18 22:29:59 2021 +0100

    Fix "ManageNetworks" use-case

    With change I603521bd00dc100e03c765c25503b5e01f3383e4
    the ManageNetworks == False use case was overlooked.

    When ManageNetworks is set to False and networks are
    not created we need to build network_attrs and
    subnet_attrs from the data present in network_data.yaml
    and parameters.

    Closes-Bug: #1920050
    Change-Id: I98a3d582add0d6881cd39433ddb25515f0e0dc31
    (cherry picked from commit 80b226c44ce55506460a4914e2d7f2e2de1b41e8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 13.3.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/832669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/832669
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/3d4d75b8339e9bef4a304e4e71dd81a38914daae
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 3d4d75b8339e9bef4a304e4e71dd81a38914daae
Author: Harald Jensås <email address hidden>
Date: Thu Mar 18 22:29:59 2021 +0100

    Fix "ManageNetworks" use-case

    With change I603521bd00dc100e03c765c25503b5e01f3383e4
    the ManageNetworks == False use case was overlooked.

    When ManageNetworks is set to False and networks are
    not created we need to build network_attrs and
    subnet_attrs from the data present in network_data.yaml
    and parameters.

    The network_attrs and subnet_attrs was backported to
    ussuri and train in change:
    I3309f2a0e39ad115930ecd5c0e895816565819e9

    osp-director-operator need this fix as it is using
    manage_networks: false.

    Conflicts:
        network/network.j2

    Closes-Bug: #1920050
    Change-Id: I98a3d582add0d6881cd39433ddb25515f0e0dc31
    (cherry picked from commit 80b226c44ce55506460a4914e2d7f2e2de1b41e8)
    (cherry picked from commit d39526de13d0603c92b2e0dd2c0ff6a42257301f)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/833196

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/833196
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/497d3f6b935ad88da564e11ec61f9cd27cd284e1
Submitter: "Zuul (22348)"
Branch: stable/train

commit 497d3f6b935ad88da564e11ec61f9cd27cd284e1
Author: Harald Jensås <email address hidden>
Date: Thu Mar 18 22:29:59 2021 +0100

    Fix "ManageNetworks" use-case

    With change I603521bd00dc100e03c765c25503b5e01f3383e4
    the ManageNetworks == False use case was overlooked.

    When ManageNetworks is set to False and networks are
    not created we need to build network_attrs and
    subnet_attrs from the data present in network_data.yaml
    and parameters.

    The network_attrs and subnet_attrs was backported to
    ussuri and train in change:
    I3309f2a0e39ad115930ecd5c0e895816565819e9

    osp-director-operator need this fix as it is using
    manage_networks: false.

    Conflicts:
        network/network.j2

    Closes-Bug: #1920050
    Change-Id: I98a3d582add0d6881cd39433ddb25515f0e0dc31
    (cherry picked from commit 80b226c44ce55506460a4914e2d7f2e2de1b41e8)
    (cherry picked from commit d39526de13d0603c92b2e0dd2c0ff6a42257301f)
    (cherry picked from commit 3d4d75b8339e9bef4a304e4e71dd81a38914daae)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates ussuri-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.