© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
- Root Cause Analysis (RCA) on why we needed to revert patch 772755
- PROBLEM: On master - patch 772755 is causing an error when a playbook contains an empty group list []
- 772755: Add an error message when groups is not found in the playbook
- https:/
- TESTED: 16.1: patch 772755 WORKED, as validation.py did not have the change to return an empty group list [] when a group is not found.
- TESTED: Master: patch 772755 FAILED
- SOLUTION: Revert patch https:/
The following is a Root Cause Analysis (RCA) on why we needed to revert patch 772755
Summary:
- 16.1 - getting error "IndexError: list index out of range" when playbook does not contain group property.
- 16.1 - to reproduce on 16.1, using node-health.yaml as playbook
- Modify node-health.yaml and comment out groups:
- /usr/share/
- Run command to show problem
- FIX - file utils.py was modified to report more info about the problem
- 16.1: ORIGINAL version iterates through and returns with above python fault.
- 16.1: FIXED - see box below - we changed things to return with informative error if/when groups are NOT FOUND.
- Merge to master - turns out, above patch was NOT necessary - since code in master was changed to return
an empty list if the key was not found.
- master: code in master was changed to return an empty list if the key was not found.
- For example - ceph-pg.yaml - contains an empty [] group list - which is valid.
- master: the empty [] group list is VALID - thus we need to remove our initial patch.
Detail:
- 16.1 - getting error "IndexError: list index out of range" when playbook does not contain group property.
- 16.1 - to reproduce on 16.1, using node-health.yaml as playbook
- Modify node-health.yaml and comment out groups:
- /usr/share/
---
- hosts: undercloud
vars:
metadata:
name: Node health check
Check if all overcloud nodes can be connected to before starting a
scale-up or an upgrade.
# groups:
# - pre-upgrade
roles:
- node_health
- Run command to show problem
openstack tripleo validator run --group pre-update
(undercloud) [stack@undercloud-0 ansible]$ openstack tripleo validator run --group pre-update
Exception occured while running the command
Traceback (most recent call last):
File "/usr/lib/
super(
File "/usr/lib/
return super(Command, self).run(
File "/usr/lib/
return_code = self.take_
File "/usr/lib/
self.
File "/usr/lib/
t.field_names = results[0].keys()
IndexError: list index out of range
list index out of range
- FIX - file utils.py was modified to report more info about the problem
- 16.1: ORIGINAL version iterates through and returns with above python fault.
// version: 16.1
// file: /usr/lib/
def parse_all_
"""
Return a list of validations metadata
Can be sorted by Groups
"""
results = []
validations
if isinstance(groups, six.string_types):
groups = [groups]
for pl in validations_
val = Validation(pl)
|if not groups or set(groups)
| results.
return results
- 16.1: FIXED - see box below - we changed things to return with informative error if/when groups are NOT FOUND.
// version: master
// file: validations-
// gerrit patch: https:/
def parse_all_
results = []
if not groups:
groups = []
else:
groups = convert_
validations
for pl in validations_
val = Validation(pl)
|if not val.groups: |
| msg = 'Group not found in playbook - please add appropriate group'|
| raise RuntimeError(msg) |
if not groups or set(groups)
return results
- We tested above fix manually on 16.1
- Merge to master - turns out, above patch was NOT necessary - since code in master was changed to return an empty list if the key was not found.
- master: code in master was changed to return an empty list if the key was not found.
// version: master
// file: validations-
// diff/patch: https:/
@property
def groups(self):
- return self.dict[
+ |if self.has_
+ | groups = self.dict[
+ | if groups: |
+ | return groups |
+ | else: |
+ | return [] |
+ |else: |
+ | raise NameError( |
+ | "No metadata found in validation {}".format(self.id) |
+ | ) |
| |
- For example - ceph-pg.yaml - contains an empty [] group list - which is valid.
// version: master
// file: tripleo-
// gerrit patch: https:/
---
- hosts: undercloud
vars:
metadata:
name: Validate requested Ceph Placement Groups
In Ceph Lumionus and newer the Placement Group overdose protection check
(https:/
executed by Ceph before a pool is created. If the check does not pass,
then the pool is not created. When TripleO deploys Ceph it triggers
determine if the user should update their CephPools, PG count, or number
of OSD. Without this check a deployer may have to wait until after Ceph
is running but before the pools are created to realize the deployment
will fail.
+----------+
|groups: []|
+----------+
tasks:
- include_role:
name: ceph
- master: the empty [] group list is VALID - thus we need to remove our initial patch.
// version: master
// file: validations-
// gerrit patch: https:/
|if not val.groups: | <<< REMOVE
| msg = 'Group not found in playbook - please add appropriate group'| <<< REMOVE
| raise RuntimeError(msg) | <<< REMOVE