Victoria Container build job is failing, buildah deprecations warning is added as a first item in the list instead of container name

[Sandeep Yadav]

Description:

Victoria Container build job is failing, buildah deprecations warning is added as a first item in the list instead of container name

Logs snippet:

https://logserver.rdoproject.org/openstack-periodic-integration-stable1/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-build-containers-ubi-8-push-victoria/d2783f2/job-output.txt

```
2021-02-24 09:57:54.959386 | LOOP [build-containers : Tag images]
2021-02-24 09:57:55.050593 | primary | ok: "time=\"2021-02-24T09:57:44Z\" level=warning msg=\"Found deprecated file /usr/share/containers/libpod.conf, please remove. Use /etc/containers/containers.conf to override defaults.\\n\""
2021-02-24 09:57:55.051106 |
```
buildah deprecations warning is added as a first item in the list instead of container name
```
2021-02-24 09:57:57.359642 | LOOP [build-containers : Tag w/ arch suffix and push image: time="2021-02-24T09:57:44Z" level=warning msg="Found deprecated file /usr/share/containers/libpod.conf, please remove. Use /etc/containers/containers.conf to override defaults.\n"]
2021-02-24 09:57:57.876110 | primary | time="2021-02-24T09:57:57Z" level=warning msg="Found deprecated file /usr/share/containers/libpod.conf, please remove. Use /etc/containers/containers.conf to override defaults.\n"
2021-02-24 09:57:57.876726 | primary | error finding local image "time=2021-02-24T09:57:44Z": error parsing name "time=2021-02-24T09:57:44Z": error parsing image name "time=2021-02-24T09:57:44Z": invalid reference format: repository name must be lowercase
2021-02-24 09:57:58.256299 | primary | time="2021-02-24T09:57:58Z" level=warning msg="Found deprecated file /usr/share/containers/libpod.conf, please remove. Use /etc/containers/containers.conf to override defaults.\n"
2021-02-24 09:57:58.256543 | primary | Only two arguments are necessary to push: source and destination
2021-02-24 09:57:58.285170 |
```

The same deprecation message is used by buildah to push the container, there is no containers names having deprecations as a name.

We have new a buildah rpm:-

Earlier good job:-
https://logserver.rdoproject.org/openstack-periodic-integration-stable1/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-build-containers-ubi-8-push-victoria/f762be7/logs/system/installed_pkgs.txt
~~~
buildah.x86_64 1.15.1-2.module_el8.3.0+475+c50ce30b @appstream
~~~

Currently affected job:-
https://logserver.rdoproject.org/openstack-periodic-integration-stable1/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-build-containers-ubi-8-push-victoria/d2783f2/logs/system/installed_pkgs.txt
~~~
buildah.x86_64 1.16.7-4.module_el8.3.0+699+d61d9c41 @appstream
~~~

[Sandeep Yadav (sandeepyadav93)]

Warning on every buildah command:-

WARN[0000] Found deprecated file /usr/share/containers/libpod.conf, please remove. Use /etc/containers/containers.conf to override defaults.

~~~
[root@node-0000915416 ~]# buildah images
WARN[0000] Found deprecated file /usr/share/containers/libpod.conf, please remove. Use /etc/containers/containers.conf to override defaults.
REPOSITORY TAG IMAGE ID CREATED SIZE
trunk.registry.rdoproject.org/tripleovictoria/openstack-mistral-executor 2593367205e6c58cad8437f3359546d3 79adc66fe955 2 hours ago 1.77 G
~~~

[Sandeep Yadav (sandeepyadav93)]

We reported an issue in upstream buildah

"buildah images --log-level error still shows the warning messages #3040"

https://github.com/containers/buildah/issues/3040

[Bhagyashri Shewale (bhagyashri-shewale)]

Hi All,

Ths patch [1] resolves this issue.

Add workaround for container build

Latest buildah.x86_64 1.16.7-4 is throwing below warning:-
~~~
[root@node-0000915416 ~]# buildah images
WARN[0000] Found deprecated file /usr/share/containers/libpod.conf,
please remove. Use /etc/containers/containers.conf to override defaults.
REPOSITORY TAG IMAGE ID CREATED SIZE
~~~

The above buildah deprecations warning is getting added as a
first item in the list instead of container name, details in bug[1]

With this patch, we are moving /usr/share/containers/libpod.conf to
/usr/share/containers/libpod.conf_backup to avoid the warning as a
workaround.

[1] https://bugs.launchpad.net/tripleo/+bug/1916742
Closes-Bug: #1916742

Change-Id: Ia4a892007b33ed991c6fefc19cbd3683086d5148

https://review.opendev.org/c/openstack/tripleo-ci/+/777378

[Ronelle Landy (rlandy)]

workaround/fix is in- closing out