Outdated/incorrect hieradata definitions in THT

[Alexey Stupnikov]

There are a number of hieradata definitions in THT which no longer present in appropriate puppet projects and could be misleading for users and new developers.

Project-specific details would be provided in comments.

[Alexey Stupnikov (astupnikov)]

https://review.opendev.org/q/topic:%22bug%252F1916386%22+(status:open%20OR%20status:merged)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/780416
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/e3f1ad953dff4f3304a050d50589121a6e872d25
Submitter: "Zuul (22348)"
Branch: master

commit e3f1ad953dff4f3304a050d50589121a6e872d25
Author: Alexey Stupnikov <email address hidden>
Date: Sat Mar 13 15:20:03 2021 +0100

    Remove or fix outdated/incorrect keystone hieradata definitions

    - keystone::wsgi::apache::servername_admin was removed in Train
      change: I859803f1d79304de5a803753841e994357b045f8

    Partial-Bug: #1916386
    Change-Id: I340884cbde1ddfa86366a7ba1908087b08a05c85

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786402

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786402
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/dc083686dee210a1b81a32da2ff1f1a0f17ec324
Submitter: "Zuul (22348)"
Branch: master

commit dc083686dee210a1b81a32da2ff1f1a0f17ec324
Author: Alexey Stupnikov <email address hidden>
Date: Thu Apr 15 14:55:49 2021 +0200

    Remove heat::heat_keystone_clients_url definition

    During Queens release cycle it was decided that
    clients_keystone/auth_uri should be defined and should point to
    public URL to allow instances run some API calls.

    Two changes were added:

    - I4429d86d831f49f1bc0fef04379a81ada20b6ab6 was used to add
      related definitions to puppet-heat
    - Ib1cb8a5da886e3f7afd88f8dc9d63f0847f677bd was used to add
      appropriate hiera defition to THT

    But hiera definition in THT was incorrect:
    heat::heat_keystone_clients_url was defined instead of
    heat::heat_clients_keystone_uri.

    heat_clients_keystone_uri parameter was removed from puppet-heat
    during Train release cycle:
    I507fd2beecface5f8de35d18bfb546a653c6ef51

    Partial-Bug: #1916386
    Change-Id: I2797da50489e3812aa58415e2e6ba44894a89094

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/791131

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796656

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796657

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/797085

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/797094

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/780413
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/02bb4b8aa095619f2bc07aeb7302c2f333093569
Submitter: "Zuul (22348)"
Branch: master

commit 02bb4b8aa095619f2bc07aeb7302c2f333093569
Author: Alexey Stupnikov <email address hidden>
Date: Sat Mar 13 13:58:46 2021 +0100

    Remove or fix outdated/incorrect neutron hieradata definitions

    - neutron::server::qos_notification_drivers was deprecated in Ocata
      change: Ie95e8d07273d168da0fe9ae1635774b230683efa
    - neutron::server::placement::www_authenticate_uri is incorrect:
      neutron::server::placement::auth_url should be used instead and it is
      already defined
    - neutron::agents::ml2::networking_baremetal::username should be used
      instead of neutron::agents::ml2::networking_baremetal::user
    - neutron::agents::metadata::auth_password,
      neutron::agents::metadata::auth_url and
      neutron::agents::metadata::auth_tenant were deprecated in Newton
      change: I2c88f8523630ad0246785190f90b7a02fc704153
    - neutron::agents::ovn_metadata::auth_password,
      neutron::agents::ovn_metadata::auth_url and
      neutron::agents::ovn_metadata::auth_tenant are likely artifacts that
      were not removed when service template for OVN Metadata service was
      copied from Neutron Metadata service definition.

    Partial-Bug: #1916386
    Change-Id: Ib4d09589c8558fbd72c69a7b5b21bc9e0fc97f32

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796656
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/5e941e4ef217fdb58429045809c4592f3ce03b33
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit 5e941e4ef217fdb58429045809c4592f3ce03b33
Author: Alexey Stupnikov <email address hidden>
Date: Thu Apr 15 14:55:49 2021 +0200

    Remove heat::heat_keystone_clients_url definition

    During Queens release cycle it was decided that
    clients_keystone/auth_uri should be defined and should point to
    public URL to allow instances run some API calls.

    Two changes were added:

    - I4429d86d831f49f1bc0fef04379a81ada20b6ab6 was used to add
      related definitions to puppet-heat
    - Ib1cb8a5da886e3f7afd88f8dc9d63f0847f677bd was used to add
      appropriate hiera defition to THT

    But hiera definition in THT was incorrect:
    heat::heat_keystone_clients_url was defined instead of
    heat::heat_clients_keystone_uri.

    heat_clients_keystone_uri parameter was removed from puppet-heat
    during Train release cycle:
    I507fd2beecface5f8de35d18bfb546a653c6ef51

    Partial-Bug: #1916386
    Change-Id: I2797da50489e3812aa58415e2e6ba44894a89094
    (cherry picked from commit dc083686dee210a1b81a32da2ff1f1a0f17ec324)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/797094
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/378f65240fe9156903fadd510fea429e5107ede9
Submitter: "Zuul (22348)"
Branch: stable/train

commit 378f65240fe9156903fadd510fea429e5107ede9
Author: Alexey Stupnikov <email address hidden>
Date: Thu Apr 15 14:55:49 2021 +0200

    Remove heat::heat_keystone_clients_url definition

    During Queens release cycle it was decided that
    clients_keystone/auth_uri should be defined and should point to
    public URL to allow instances run some API calls.

    Two changes were added:

    - I4429d86d831f49f1bc0fef04379a81ada20b6ab6 was used to add
      related definitions to puppet-heat
    - Ib1cb8a5da886e3f7afd88f8dc9d63f0847f677bd was used to add
      appropriate hiera defition to THT

    But hiera definition in THT was incorrect:
    heat::heat_keystone_clients_url was defined instead of
    heat::heat_clients_keystone_uri.

    heat_clients_keystone_uri parameter was removed from puppet-heat
    during Train release cycle:
    I507fd2beecface5f8de35d18bfb546a653c6ef51

    (To Ussuri)
    Conflicts:
            deployment/heat/heat-base-puppet.yaml

    Partial-Bug: #1916386
    Change-Id: I2797da50489e3812aa58415e2e6ba44894a89094
    (cherry picked from commit dc083686dee210a1b81a32da2ff1f1a0f17ec324)
    (cherry picked from commit c3f91bcd7608428fa6e65cdf155ebe8f1e8c0cd0)
    (cherry picked from commit 0ed341f447aaec139fb0c39ff643d8e75f015712)
    (cherry picked from commit 819870702e43773a5c320eb5fdc860ee465c7bf1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/797085
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/819870702e43773a5c320eb5fdc860ee465c7bf1
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 819870702e43773a5c320eb5fdc860ee465c7bf1
Author: Alexey Stupnikov <email address hidden>
Date: Thu Apr 15 14:55:49 2021 +0200

    Remove heat::heat_keystone_clients_url definition

    During Queens release cycle it was decided that
    clients_keystone/auth_uri should be defined and should point to
    public URL to allow instances run some API calls.

    Two changes were added:

    - I4429d86d831f49f1bc0fef04379a81ada20b6ab6 was used to add
      related definitions to puppet-heat
    - Ib1cb8a5da886e3f7afd88f8dc9d63f0847f677bd was used to add
      appropriate hiera defition to THT

    But hiera definition in THT was incorrect:
    heat::heat_keystone_clients_url was defined instead of
    heat::heat_clients_keystone_uri.

    heat_clients_keystone_uri parameter was removed from puppet-heat
    during Train release cycle:
    I507fd2beecface5f8de35d18bfb546a653c6ef51

    (To Ussuri)
    Conflicts:
            deployment/heat/heat-base-puppet.yaml

    Partial-Bug: #1916386
    Change-Id: I2797da50489e3812aa58415e2e6ba44894a89094
    (cherry picked from commit dc083686dee210a1b81a32da2ff1f1a0f17ec324)
    (cherry picked from commit c3f91bcd7608428fa6e65cdf155ebe8f1e8c0cd0)
    (cherry picked from commit 0ed341f447aaec139fb0c39ff643d8e75f015712)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/796657
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/0ed341f447aaec139fb0c39ff643d8e75f015712
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 0ed341f447aaec139fb0c39ff643d8e75f015712
Author: Alexey Stupnikov <email address hidden>
Date: Thu Apr 15 14:55:49 2021 +0200

    Remove heat::heat_keystone_clients_url definition

    During Queens release cycle it was decided that
    clients_keystone/auth_uri should be defined and should point to
    public URL to allow instances run some API calls.

    Two changes were added:

    - I4429d86d831f49f1bc0fef04379a81ada20b6ab6 was used to add
      related definitions to puppet-heat
    - Ib1cb8a5da886e3f7afd88f8dc9d63f0847f677bd was used to add
      appropriate hiera defition to THT

    But hiera definition in THT was incorrect:
    heat::heat_keystone_clients_url was defined instead of
    heat::heat_clients_keystone_uri.

    heat_clients_keystone_uri parameter was removed from puppet-heat
    during Train release cycle:
    I507fd2beecface5f8de35d18bfb546a653c6ef51

    Partial-Bug: #1916386
    Change-Id: I2797da50489e3812aa58415e2e6ba44894a89094
    (cherry picked from commit dc083686dee210a1b81a32da2ff1f1a0f17ec324)
    (cherry picked from commit c3f91bcd7608428fa6e65cdf155ebe8f1e8c0cd0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/782424
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/9e8061ae7c9e59ae1b27a2d71d07b054a57defae
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 9e8061ae7c9e59ae1b27a2d71d07b054a57defae
Author: Alexey Stupnikov <email address hidden>
Date: Wed Mar 3 20:42:48 2021 +0100

    Fix NovaDefaultFloatingPool parameter

    nova::api::default_floating_pool parameter was removed from
    puppet-nova back in 2018 with
    I2624b92871f4cba5a7361a5d006d985946493e83

    It is now recommended to use
    nova::network::neutron::default_floating_pool parameter to
    define default floating IP pool.

    Partial-Bug: #1916386
    Change-Id: If419d53fc3a90cdd62271c00714fff79a3b4fd12
    (cherry picked from commit a6c1aff5c5b1c8e855f9740b217f9545f7bb0116)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/791131
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/ab9f26b305ce3ee71b51c8d2230171f0574425d3
Submitter: "Zuul (22348)"
Branch: master

commit ab9f26b305ce3ee71b51c8d2230171f0574425d3
Author: Alexey Stupnikov <email address hidden>
Date: Thu May 13 12:44:56 2021 +0200

    Remove or fix outdated/incorrect tripleo hieradata definitions

    - tripleo::profile::base::database::mysql::client_bind_address
      definition was removed. This parameter looks like an artifact
      from Newton release when separate class for client configuration
      tripleo::profile::base::database::mysql::client was introduced.
    - tripleo::profile::pacemaker::database::redis_bundle::control_port
      parameter was renamed to
      tripleo::profile::pacemaker::database::redis_bundle::redis_docker_control_port
    - tripleo::haproxy::panko definition was removed: related
      puppet-tripleo definition was removed during Ussuri release
      I3ef5c1433691dd31b619e0fdbd5ec433a181ec03
    - tripleo::haproxy::ec2_api and tripleo::haproxy::ec2_api_metadata
      parameters were removed: related puppet-tripleo definitons
      were removed during Victoria release
      I9ce13aefb82cbcada5466cd3dddf851cfc51bacc
    - multiple tripleo::profile::pacemaker::rabbitmq_bundle::control_port
      parameter definitions were renamed to
      tripleo::profile::pacemaker::rabbitmq_bundle::rabbitmq_docker_control_port

    Partial-Bug: #1916386
    Change-Id: Icfb9c5c37283f1c94cd870305aa51c9605b901b3