openstack tripleo validator run doesn't fail if a validation fails

Bug #1915154 reported by Sofer Athlan-Guyot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Gael Chamoulaud

Bug Description

Hi,

context: we trying to add validation to the update process, but the validation command doesn't fail even if the the test fails:

undercloud-0 tripleo-validations]$ openstack --os-cloud undercloud tripleo validator run --stack undercloud --group pre-system-upgrade
[WARNING]: Found both group and host with same name: undercloud
Tuesday 09 February 2021 13:59:25 +0000 (0:00:00.063) 0:00:00.063 ******
Tuesday 09 February 2021 13:59:26 +0000 (0:00:00.771) 0:00:00.834 ******
Tuesday 09 February 2021 13:59:26 +0000 (0:00:00.112) 0:00:00.947 ******
Tuesday 09 February 2021 13:59:30 +0000 (0:00:03.507) 0:00:04.454 ******
Tuesday 09 February 2021 13:59:30 +0000 (0:00:00.062) 0:00:04.516 ******
Tuesday 09 February 2021 13:59:30 +0000 (0:00:00.118) 0:00:04.635 ******
Tuesday 09 February 2021 13:59:30 +0000 (0:00:00.110) 0:00:04.746 ******
Tuesday 09 February 2021 13:59:30 +0000 (0:00:00.169) 0:00:04.915 ******

Tuesday 09 February 2021 13:59:30 +0000 (0:00:00.111) 0:00:05.027 ******
===============================================================================
package_version : Get repositories packages versions -------------------- 3.51s
package_version : Ensure we get needed facts ---------------------------- 0.77s
package_version : Do the comparison ------------------------------------- 0.17s
package_version : Compare versions -------------------------------------- 0.12s
package_version : Gather variables for each operating system ------------ 0.11s
package_version : Fail if we lack a version for any package ------------- 0.11s
package_version : Get wanted package ------------------------------------ 0.11s
package_version : Initialiaze ok_versions ------------------------------- 0.06s
+--------------------------------------+-----------------+--------+------------+----------------+-------------------+-------------+
| UUID | Validations | Status | Host_Group | Status_by_Host | Unreachable_Hosts | Duration |
+--------------------------------------+-----------------+--------+------------+----------------+-------------------+-------------+
| dc8ee383-7653-43c1-abee-eaeabe3ec37b | package-version | FAILED | all | undercloud | | 0:00:04.977 |
+--------------------------------------+-----------------+--------+------------+----------------+-------------------+-------------+

echo $?
0

The question is then what is the proper way to detect that a validation failed ?

Tags: validations
Revision history for this message
Sofer Athlan-Guyot (sofer-athlan-guyot) wrote :
Revision history for this message
Gael Chamoulaud (gael-chamoulaud) wrote :
Changed in tripleo:
assignee: nobody → Gael Chamoulaud (gael-chamoulaud)
Revision history for this message
Marios Andreou (marios-b) wrote :

moving fix-released based on comment #2 looks like that is all merged.

Changed in tripleo:
status: New → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 14.2.0

This issue was fixed in the openstack/python-tripleoclient 14.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.5.0

This issue was fixed in the openstack/python-tripleoclient 12.5.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.4.3

This issue was fixed in the openstack/python-tripleoclient 13.4.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.