validate_upgrade_tasks_duplicate_whens detects false positive.

[Sofer Athlan-Guyot]

Hi,

if you setup some output tasks in a template like this:

  upgrade_tasks:
    - block:
        - debug: "bar"
          when: 1 == 1
      when: 0 == 0

then we get:

ERROR: found duplicate when statements in ./puppet/services/test.yaml upgrade_task: when: 1 == 1 when: 0 == 0

that's because the check in validate_upgrade_tasks_duplicate_whens in ./tool/yaml_validate.py doesn't support this kind of block syntax and take the second when statement as belonging to the task in the block.

there are other flaws in that function, like it start at upgrade_tasks and include everything till the end of the file, even if that's not upgrade_tasks definition anymore.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

Fun facts.

if you have this

  upgrade_tasks:
    - block:
        - name: funny
          when: 1 == 1
          shell: "bar --like foo"
      when: 0 == 0

then it works because " -" is seen as the beginning of a new task and reset counters.

[Sofer Athlan-Guyot (sofer-athlan-guyot)]

This was discovered in that review https://review.opendev.org/c/openstack/tripleo-heat-templates/+/769393/3/puppet/services/docker.yaml