HorizonDebug is not correctly honored

[Takashi Kajinami]

Currently Debug parameters(Debug and HorizonDebug) are used to set horizon::django_debug and horizon::log_level but there are some problems with the current implementation.

1. HorizonDebug is ineffective for horizon::django_debug, because of inproper conditions debug_unset which is always True.

2. When Horizon: true and HorizonDebug: false are set, horizon::log_level is set to DEBUG, while we
generally expect that service specific debug parameters override the common debug parameter.

[Marios Andreou (marios-b)]

Fix from Takashi at

        * Fix logic to honor HorizonDebug
        * Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b
        * https://review.opendev.org/c/openstack/tripleo-heat-templates/+/767281

[Marios Andreou (marios-b)]

(copy/pasting from Takashi @ https://review.opendev.org/c/openstack/tripleo-heat-templates/+/767281/4//COMMIT_MSG#15 )

I confirmed that debug is disabled as expected in CI result (because we have Debug:true set)
https://6858d98d7a501e0358b0-54baced7b3de4d4a8f29448d2e5adbbf.ssl.cf2.rackcdn.com/767281/5/check/tripleo-ci-centos-8-standalone/9bac17b/logs/undercloud/var/lib/config-data/puppet-generated/horizon/etc/openstack-dashboard/local_settings

I changed the default of HorizonDebug to false in the subsequent commit and confirmed that debug is disabled.

https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_9c6/768177/1/check/tripleo-ci-centos-8-standalone/9c6c1a2/logs/undercloud/var/lib/config-data/puppet-generated/horizon/etc/openstack-dashboard/local_settings

The other services like nova have debug disabled so HorizonDebug is effective for only debug in Horizon and overrides the Debug parameter.

[Marios Andreou (marios-b)]

test review @

        * DNM: Test behavior of HorizonDebug
        * Change-Id: I19dc259e455456a01718f2c5c3e3086bea95588c
        * https://review.opendev.org/c/openstack/tripleo-heat-templates/+/768177

[Takashi Kajinami (kajinamit)]

Thank you, Marios, for posting these information.

Let me correct one mistake I made in my original comment.

> I confirmed that debug is disabled as expected in CI result (because we have Debug:true set)
I should have said;

I confirmed that debug is ENABLED as expected in CI result (because we have Debug:true set)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 14.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.5.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.4.3 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/772658
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/bb7d59c65a1c0feacfa4b05904dfe3f4ca287cdf
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit bb7d59c65a1c0feacfa4b05904dfe3f4ca287cdf
Author: Takashi Kajinami <email address hidden>
Date: Wed Dec 16 16:30:39 2020 +0900

    Fix logic to honor HorizonDebug

    Debug always has one of true/false and is always set. We should check
    whether HorizonDebug is set instead of whether Debug is set.

    Also, this change fixes the current logic to make sure that
    HorizonDebug: false is honored even when Debug: true is set.

    Closes-Bug: #1908362
    Change-Id: I514b5a3d4133d3561376ea06a803d019acaa0f0b
    (cherry picked from commit f89140402ef211f92309646c2d935d5b9e593f99)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 13.5.0 release.