tripleo

ExtraConfigPre and NodeExtraConfig are executed before network settings are applied

Bug #1907214 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Takashi Kajinami

Bug Description

Currently ExtraConfigPre and NodeExtraConfig, are executed before network settigs are applied. This is different from old versions like Queens, in which these resources are executed after network configuration.

Some users currently use these resources to apply some configurations which depend on network connectivity on networks which are different from provisioning network in old releases like Queens, and this change in resource order causes failure with such implementations in current releases.

See original description
Takashi Kajinami (kajinamit)
Changed in tripleo:
assignee: nobody → Takashi Kajinami (kajinamit)
description: updated
Bogdan Dobrelya (bogdando)
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
milestone: none → wallaby-2
tags: added: queens-backport-potential
tags: added: train-backport-potential
removed: queens-backport-potential
Bogdan Dobrelya (bogdando)
tags: added: ux
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/ussuri)

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-common/+/786901

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-common (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-common/+/786902

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786891

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786892

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/783554
Committed: https://opendev.org/openstack/tripleo-common/commit/adfee2e68d9efaac7b7b3f24f428ee1d366003cb
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit adfee2e68d9efaac7b7b3f24f428ee1d366003cb
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 25 19:53:08 2021 +0900

    Add host_vars to define tasks executed before network configurations

    This change is a prep work to ensure tasks defined in ExtraConfigPre
    and NodeExtraConfig are executed after network configurations.

    Related-Bug: #1907214
    Change-Id: I0e45090f8db1c1737e69ce906a12027bfe5c3ef0
    (cherry picked from commit f19f451f88141c656c18a1c2a96b49874cfb1b0d)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/786901
Committed: https://opendev.org/openstack/tripleo-common/commit/8a3a319492b82034b0e3515b5c4fa9c032148511
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 8a3a319492b82034b0e3515b5c4fa9c032148511
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 25 19:53:08 2021 +0900

    Add host_vars to define tasks executed before network configurations

    This change is a prep work to ensure tasks defined in ExtraConfigPre
    and NodeExtraConfig are executed after network configurations.

    Related-Bug: #1907214
    Change-Id: I0e45090f8db1c1737e69ce906a12027bfe5c3ef0
    (cherry picked from commit f19f451f88141c656c18a1c2a96b49874cfb1b0d)
    (cherry picked from commit adfee2e68d9efaac7b7b3f24f428ee1d366003cb)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-common (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-common/+/786902
Committed: https://opendev.org/openstack/tripleo-common/commit/f86958465cc342a7b1b5947b586467a1f2ff3d80
Submitter: "Zuul (22348)"
Branch: stable/train

commit f86958465cc342a7b1b5947b586467a1f2ff3d80
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 25 19:53:08 2021 +0900

    Add host_vars to define tasks executed before network configurations

    This change is a prep work to ensure tasks defined in ExtraConfigPre
    and NodeExtraConfig are executed after network configurations.

    Related-Bug: #1907214
    Change-Id: I0e45090f8db1c1737e69ce906a12027bfe5c3ef0
    (cherry picked from commit f19f451f88141c656c18a1c2a96b49874cfb1b0d)
    (cherry picked from commit adfee2e68d9efaac7b7b3f24f428ee1d366003cb)
    (cherry picked from commit 8a3a319492b82034b0e3515b5c4fa9c032148511)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 14.1.0

This issue was fixed in the openstack/tripleo-heat-templates 14.1.0 release.

Marios Andreou (marios-b)
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/783555
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/87fc83d7b1334dd2bd5852ae9edf44f87d29e79c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 87fc83d7b1334dd2bd5852ae9edf44f87d29e79c
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 25 19:57:02 2021 +0900

    Restore PreNetworkConfig resources

    This change restores the PreNetworkConfig resources, so that we migrate
    back ExtraCnfigPre and NodeExtraConfig from pre network configurations
    to post network configurations, to be consistent with older version
    depending on Heat software deployments instead of config download.

    Depends-on: https://review.opendev.org/783554
    Closes-Bug: #1907214
    Change-Id: I96e7e4c570839cfba6011788464d8e93925b2f01
    (cherry picked from commit e7894c0b2308692364b72a7dc22cb5a32cd5c3b8)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786891
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/ef575f87f51686a9c65a1a33d4933191c052a5e0
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit ef575f87f51686a9c65a1a33d4933191c052a5e0
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 25 19:57:02 2021 +0900

    Restore PreNetworkConfig resources

    This change restores the PreNetworkConfig resources, so that we migrate
    back ExtraCnfigPre and NodeExtraConfig from pre network configurations
    to post network configurations, to be consistent with older version
    depending on Heat software deployments instead of config download.

    Conflicts:
            common/deploy-steps.j2

    Depends-on: https://review.opendev.org/786901
    Closes-Bug: #1907214
    Change-Id: I96e7e4c570839cfba6011788464d8e93925b2f01
    (cherry picked from commit e7894c0b2308692364b72a7dc22cb5a32cd5c3b8)
    (cherry picked from commit 87fc83d7b1334dd2bd5852ae9edf44f87d29e79c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 13.3.0

This issue was fixed in the openstack/tripleo-heat-templates 13.3.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.4.4

This issue was fixed in the openstack/tripleo-heat-templates 12.4.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/786892
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/83e99c65a28b15557c42a194dfdaaec5c2edf8d4
Submitter: "Zuul (22348)"
Branch: stable/train

commit 83e99c65a28b15557c42a194dfdaaec5c2edf8d4
Author: Takashi Kajinami <email address hidden>
Date: Mon Jan 25 19:57:02 2021 +0900

    Run ExtraConfigPre and NodeExtraConfig after network configurations

    This change makes ExtraCnfigPre and NodeExtraConfig executed after
    network configurations, so that these resources are triggered at
    the consistent timing with older version depending on Heat software
    deployments instead of config download.

    Conflicts:
            common/deploy-steps.j2

    Backport note to train:
    PreNetworkConfig resource still exists in stable/train so commit
    message and release note are updated accordinly.

    Conflicts:
            common/deploy-steps.j2
            puppet/role.role.j2.yaml

    Depends-on: https://review.opendev.org/786901
    Closes-Bug: #1907214
    Change-Id: I96e7e4c570839cfba6011788464d8e93925b2f01
    (cherry picked from commit e7894c0b2308692364b72a7dc22cb5a32cd5c3b8)
    (cherry picked from commit 87fc83d7b1334dd2bd5852ae9edf44f87d29e79c)
    (cherry picked from commit ef575f87f51686a9c65a1a33d4933191c052a5e0)

Marios Andreou (marios-b)
Changed in tripleo:
milestone: xena-1 → xena-2
Revision history for this message
Takashi Kajinami (kajinamit) wrote :

This was fixed during Wallaby cycle by

 https://review.opendev.org/c/openstack/tripleo-common/+/772303
 https://review.opendev.org/c/openstack/tripleo-heat-templates/+/772307

and that fix is included in tht 15.0.0

Changed in tripleo:
status: Triaged → Fix Released
milestone: xena-2 → none
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates train-eol

This issue was fixed in the openstack/tripleo-heat-templates train-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.