tripleo_deploy_artifacts fails with tar exit 2

[Grzegorz Grasza]

Description
===========

tripleo_deploy_artifacts module fails on my system with tar 1.30

Steps to reproduce
==================

Set the DeployArtifactURLs parameter_defaults key to a tar.gz archive.

I'm using "upload-puppet-modules -d puppet-modules" to create and upload an archive to swift.

Expected result
===============

Deployment succeeds

Actual result
=============

Deployment fails with Command 'tar xvzf -C / /tmp/tmp44hztxgx' returned non-zero exit status 2.

Executing the command manually gives the following output:

tar (child): -C: Cannot open: No such file or directory
tar (child): Error is not recoverable: exiting now
tar: Child returned status 2
tar: Error is not recoverable: exiting now

Environment
===========

master deployed on CentOS Linux release 8.2.2004 (Core)

tar (GNU tar) 1.30

Logs & Configs
==============

fatal: [compute-0]: FAILED! => {
    "changed": false,
    "error": "Traceback (most recent call last):\n File \"/tmp/ansible_tripleo_deploy_artifacts_payload_1phj4kvo/ansible_tripleo_deploy_artifacts_payload.zip/ansible/modules/tripleo_deploy_artifacts.py\", line 95, in deploy_targz\n File \"/usr/lib64/python3.6/subprocess.py\", line 438, in run\n output=stdout, stderr=stderr)\nsubprocess.CalledProcessError: Command 'tar xvzf -C / /tmp/tmp44hztxgx' returned non-zero exit status 2.\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n File \"/tmp/ansible_tripleo_deploy_artifacts_payload_1phj4kvo/ansible_tripleo_deploy_artifacts_payload.zip/ansible/modules/tripleo_deploy_artifacts.py\", line 120, in run\n File \"/tmp/ansible_tripleo_deploy_artifacts_payload_1phj4kvo/ansible_tripleo_deploy_artifacts_payload.zip/ansible/modules/tripleo_deploy_artifacts.py\", line 97, in deploy_targz\nException: Unable to install tar.gz: Command 'tar xvzf -C / /tmp/tmp44hztxgx' returned non-zero exit status 2.\n",
    "invocation": {
        "module_args": {
            "artifact_urls": [
                "http://192.168.24.3:8080/v1/AUTH_52096c560f5e43b68f7a7c79bb11a224/overcloud-artifacts/puppet-modules.tar.gz?temp_url_sig=f03f0e9935d3aed7e09daffe7468b3d4ad65ec54&temp_url_expires=1637678195"
            ]
        }
    },
    "msg": "Unhandled exception: Unable to install tar.gz: Command 'tar xvzf -C / /tmp/tmp44hztxgx' returned non-zero exit status 2."
}

[yatin (yatinkarel)]

Fix proposed with https://review.opendev.org/c/openstack/tripleo-ansible/+/763957/

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 3.0.0 release.