validations callback fails on stable/train

[Alex Schultz]

On current stable/train when trying to install an undercloud you get an error around validations:

[centos@undercloud ~]$ openstack undercloud install
[WARNING]: log file at /usr/share/openstack-tripleo-validations/playbooks/ansible.log is not writeable and we cannot create it, aborting

Using /tmp/undercloud-disk-space.yamly3979oansible.cfg as config file
Success! The validation passed for all hosts:
* undercloud
[WARNING]: Failure using method (v2_playbook_on_stats) in callback plugin (<ansible.plugins.callback.validation_json.CallbackModule object at 0x7f1b37903a10>): [Errno 2] No such file or directory:
'/var/log/validations/fa163ebf-0175-b7c1-09fb-000000000006_undercloud-disk-space_2020-11-18T19:50:23.874129Z.json'

[Cédric Jeanneret (cjeanner)]

https://review.rdoproject.org/r/#/c/31138/ should help.

[Alex Schultz (alex-schultz)]

I don't know that just creating the folder will work. I'm concerned given that it's being written to by something invoked via tripleoclient that it won't be able to write out to /var/log/validations

[Alex Schultz (alex-schultz)]

At the end of the install you also get:

[WARNING]: Failure using method (v2_playbook_on_stats) in callback plugin (<ansible.plugins.callback.validation_json.CallbackModule object at 0x7f06a1236a90>): 'module' object has no attribute 'dumps'

We likely should not have that callback included when commands that aren't validation commands

[Michele Baldessari (michele)]

Note, I also hit this on master (fwiw)

[Alex Schultz (alex-schultz)]

We should not be including the validations callback when not running validations explicitly

[Alex Schultz (alex-schultz)]

err i don't think this has been fixed