tripleo-common stable/victoria & master layout needs tidy up - remove overrides

[wes hayutin]

hrm.. check out https://review.opendev.org/#/c/762658/

tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-victoria
tripleo-ci-centos-8-scenario000-multinode-oooq-container-upgrades-victoria
tripleo-ci-centos-8-undercloud-upgrade-victoria
tripleo-ci-centos-8-standalone-upgrade-victoria

The above four jobs ran in gate.. but not check.

All gate jobs must first run in check.
:)

EDIT: no this description is wrong. please see comment #2 below. What you saw here was because the -victoria upgrade jobs only became a thing when https://review.opendev.org/#/c/760323/ was merged on Nov14th.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/762889

[Marios Andreou (marios-b)]

so they *did* run in check and gate on the bug that is not the problem here e.g. the latest has

Zuul check (2 rechecks) 2:57 PM
<snip>
tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-victoria SUCCESS in 1h 54m 33s
tripleo-ci-centos-8-scenario000-multinode-oooq-container-upgrades-victoria SUCCESS in 2h 03m 33s
tripleo-ci-centos-8-undercloud-upgrade-victoria FAILURE in 1h 06m 14s
tripleo-build-containers-ubi-8 SUCCESS in 54m 20s
tripleo-ci-centos-8-standalone-upgrade-victoria FAILURE in 1h 36m 29s

Zuul gate Nov 16 4:18 PM
tripleo-ci-centos-8-scenario000-multinode-oooq-container-updates-victoria SUCCESS in 2h 21m 56s
tripleo-ci-centos-8-scenario000-multinode-oooq-container-upgrades-victoria SUCCESS in 2h 33m 21s
tripleo-ci-centos-8-undercloud-upgrade-victoria FAILURE in 1h 04m 53s
tripleo-ci-centos-8-standalone-upgrade-victoria FAILURE in 1h 40m 27s

I guess you are referring to the early run on that patch on Nov13th which didn't have those jobs and that is likely because the -victoria upgrade jobs only became a thing when https://review.opendev.org/#/c/760323/ was merged on Nov14th.

However as we have previously discussed, yes we should ensure that the zuul layouts across the various repos are using the content provider jobs correctly.

Ideally they should just be using the templates we have defined in tripleo-ci. If there is a need to override them, then it needs to be done carefully and include all the required content provider variables etc.

Looking at the current state of https://opendev.org/openstack/tripleo-common/src/commit/5b31e6d24a51f7b166ea2e0f3865f4bbe71dff00/zuul.d/layout.yaml I think we should clean it up with your patch at https://review.opendev.org/#/c/762889/ then make sure we have that in the victoria branch for tripleo-common too.

I don't think there is a reason to override the templates like we have in that layout https://opendev.org/openstack/tripleo-common/src/commit/5b31e6d24a51f7b166ea2e0f3865f4bbe71dff00/zuul.d/layout.yaml let's remove them unless for any of them there is some reason (I am not aware of one).

[Marios Andreou (marios-b)]

removing alert tag and updating description