node_exporter container is not deployed in all the Ceph Storage nodes

[Francesco Pantano]

Setting the node_exporter container variable in the grafana templates [1] breaks some use cases where metrics should be retrieved from the all CephStorage nodes.
For this reason this variable is needed in the 'all' group and this is especially true if the operators are not using the default images (but satellite images).

[OpenStack Infra (hudson-openstack)]

Change abandoned by Francesco Pantano (<email address hidden>) on branch: master
Review: https://review.opendev.org/760217
Reason: abandoning and restoring due to CI issues

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/760217
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=51ebe2f655111508550159e170eb5050d04ccb00
Submitter: Zuul
Branch: master

commit 51ebe2f655111508550159e170eb5050d04ccb00
Author: David Hill <email address hidden>
Date: Wed Oct 28 15:46:37 2020 -0400

    node_exporter_container_image is needed in 'all' group

    ceph-ansible requires the definition of the node exporter
    container in all.yml, but at this time, the related variable
    is scoped on the Grafana server role only.
    If we want to deploy node exporter containers on all the
    overcloud nodes (including the CephStorage nodes), it is
    needed in the 'all' group and this is especially true if
    when operators are not using the default images but satellite.

    Change-Id: I7792cb252edf71ab1bb168eac1181365ca98ea7b
    Closes-Bug: #1902251

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/762286

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/762287

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/762288

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/762286
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e92bd3598d1aef191d169878d89df379aa1c4620
Submitter: Zuul
Branch: stable/victoria

commit e92bd3598d1aef191d169878d89df379aa1c4620
Author: David Hill <email address hidden>
Date: Wed Oct 28 15:46:37 2020 -0400

    node_exporter_container_image is needed in 'all' group

    ceph-ansible requires the definition of the node exporter
    container in all.yml, but at this time, the related variable
    is scoped on the Grafana server role only.
    If we want to deploy node exporter containers on all the
    overcloud nodes (including the CephStorage nodes), it is
    needed in the 'all' group and this is especially true if
    when operators are not using the default images but satellite.

    Change-Id: I7792cb252edf71ab1bb168eac1181365ca98ea7b
    Closes-Bug: #1902251
    (cherry picked from commit 51ebe2f655111508550159e170eb5050d04ccb00)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 13.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 14.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.4.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.