parameter ExternalSwiftUserTenant in template ./deployment/swift/external-swift-proxy-baremetal-puppet.yaml appears to be unused

Bug #1901652 reported by Takashi Kajinami
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Takashi Kajinami

Bug Description

While checking the output of yaml-validate.py, I noticed that the ExternalSwiftUserTenant parameter is not used in the template file at all.
We should use that parameter to determine the keystone project to which external swift user belong.

https://zuul.opendev.org/t/openstack/build/480eda6a862c436da822fd5746f7007c/log/job-output.txt#1459
~~~
2020-10-26 23:08:00.270586 | ubuntu-focal | Validating ./deployment/swift/external-swift-proxy-baremetal-puppet.yaml
2020-10-26 23:08:00.270611 | ubuntu-focal | Warning: parameter ExternalSwiftUserTenant in template ./deployment/swift/external-swift-proxy-baremetal-puppet.yaml appears to be unused
2020-10-26 23:08:00.270630 | ubuntu-focal | Validating ./deployment/swift/swift-base.yaml
~~~

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/759808

Changed in tripleo:
assignee: nobody → Takashi Kajinami (kajinamit)
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/759808
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/e618ad8d3443b3f773de52f655300ac04144b449
Submitter: "Zuul (22348)"
Branch: master

commit e618ad8d3443b3f773de52f655300ac04144b449
Author: Takashi Kajinami <email address hidden>
Date: Tue Oct 27 13:55:43 2020 +0900

    Honor the ExternalSwiftUserTenant parameter

    The ExternalSwiftUserTenant parameter is supposed to determin the
    keystone project to which the swift user belong, however in fact
    the parameter is not honored.

    This patch ensures that the parmaeter value is used as a project name
    when TripleO creates keystone resources.

    Change-Id: Ib7a173643880b573c3f30b3d990c7c617231a14c
    Closes-Bug: #1901652

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/wallaby)

Fix proposed to branch: stable/wallaby
Review: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/816133

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/wallaby)

Reviewed: https://review.opendev.org/c/openstack/tripleo-heat-templates/+/816133
Committed: https://opendev.org/openstack/tripleo-heat-templates/commit/d17f4dfc9352ea26fde42a2cc915924ad116dbce
Submitter: "Zuul (22348)"
Branch: stable/wallaby

commit d17f4dfc9352ea26fde42a2cc915924ad116dbce
Author: Takashi Kajinami <email address hidden>
Date: Tue Oct 27 13:55:43 2020 +0900

    Honor the ExternalSwiftUserTenant parameter

    The ExternalSwiftUserTenant parameter is supposed to determin the
    keystone project to which the swift user belong, however in fact
    the parameter is not honored.

    This patch ensures that the parmaeter value is used as a project name
    when TripleO creates keystone resources.

    Change-Id: Ib7a173643880b573c3f30b3d990c7c617231a14c
    Closes-Bug: #1901652
    (cherry picked from commit e618ad8d3443b3f773de52f655300ac04144b449)

tags: added: in-stable-wallaby
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 16.0.0

This issue was fixed in the openstack/tripleo-heat-templates 16.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.