[update][queens] layered openvswitch workaround is broken.

Bug #1897949 reported by Sofer Athlan-Guyot on 2020-09-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Critical
Sofer Athlan-Guyot

Bug Description

Hi,

originally reported there https://bugzilla.redhat.com/show_bug.cgi?id=1883786

Basically, we introduced a regression, that make the layer product upgrade workaround for ovs non effective.

Luckily the openvswitch workaround kicks in in all the testing we've done, so we don't get any issue, but the issue should be fixed nevertheless.

Example of what happens:

2020-09-29 14:08:00 | TASK [Get current OpenvSwitch package name] ************************************
2020-09-29 14:08:00 | Tuesday 29 September 2020 13:52:26 -0400 (0:00:00.503) 0:05:27.767 *****

2020-09-29 14:08:00 | changed: [controller-2] => {"changed": true, "cmd": "rpm -qa | awk -F- '/^(openvswitch[0-9]+\\.[0-9]+-[0-9]+\\.[0-9]+\\.[-0]+-|openvswitch-2)/{print $1}'", "delta": "0:00:01.258453", "end": "2020-09-29 17:52:27.655876", "rc": 0, "start": "2020-09-29 17:52:26.397423", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

We can see that the regex matched nothing.

Basically the regex work with:

openvswitch2.11-2.11.0-35.el7fdp.x86_64

but fails with:

openvswitch2.11-2.11.3-64.el7fdp.x86_64

Reviewed: https://review.opendev.org/755358
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4958c2ef75168d6f1840458f660a357806d4da4d
Submitter: Zuul
Branch: stable/queens

commit 4958c2ef75168d6f1840458f660a357806d4da4d
Author: Sofer Athlan-Guyot <email address hidden>
Date: Wed Sep 30 19:26:14 2020 +0200

    [QUEENS ONLY] Fix layered upgrade workaround mechanism.

    The regex was only matching ovs layered package with ".0" in the last
    number end.

    This fixes it.

    Queens only because in master and below we use
    tripleo-ansible/tripleo-ovs-upgrade module and it has the correct
    regex.

    Change-Id: I9120a7bc3b0afaf07be4ea90f65e9bb30c534fb8
    Closes-Bug: #1897949

tags: added: in-stable-queens
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers