following 3rd party integration with tcib fails

Bug #1897616 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

Following the 3rd party integration docs results in failures as we assume there is always a tcib directory in the config path and the config path top level directory is incorrectly hardcoded to be 'container-images'

https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/3rd_party.html#extend-tripleo-containers

[centos@standalone tripleo-example-integration]$ openstack tripleo container image build --config-file containers/tripleo_containers.yaml --config-path containers/
Exception occured while running the command
Traceback (most recent call last):
  File "/usr/lib/python3.6/site-packages/tripleoclient/command.py", line 34, in run
    super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/osc_lib/command/command.py", line 39, in run
    return super(Command, self).run(parsed_args)
  File "/usr/lib/python3.6/site-packages/cliff/command.py", line 187, in run
    return_code = self.take_action(parsed_args) or 0
  File "/usr/lib/python3.6/site-packages/tripleoclient/v2/tripleo_container_image.py", line 413, in take_action
    self.tcib_config_path
OSError: Configuration directory containers/tcib was not found.
Configuration directory containers/tcib was not found.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/754828

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-docs (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/754860

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-docs (master)

Reviewed: https://review.opendev.org/754860
Committed: https://git.openstack.org/cgit/openstack/tripleo-docs/commit/?id=61f60cfc86d6109122475f590a156354ba2681fd
Submitter: Zuul
Branch: master

commit 61f60cfc86d6109122475f590a156354ba2681fd
Author: Alex Schultz <email address hidden>
Date: Mon Sep 28 15:40:18 2020 -0600

    Update 3rdparty container build docs

    We've changed the structure so we need to reflect the expectations in
    the documentation.

    Change-Id: I68dbc721d12287d426b92ad820036d3795e34d28
    Related-Bug: #1897616

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/754828
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=fe7380ddff866aec9344ec3fafc3a9a2c255d445
Submitter: Zuul
Branch: master

commit fe7380ddff866aec9344ec3fafc3a9a2c255d445
Author: Alex Schultz <email address hidden>
Date: Mon Sep 28 12:18:17 2020 -0600

    Fix tcib build

    The tcib build process assumes that all the container configs exist in a
    'tcib' folder as defined via --config-path. This change documents this
    requirement and additionally we've hard coded 'container-images' in
    the image config to exclude this folder however if you define a
    custom --config-path, this fails. This change removes the hard coded
    'container-images' while documenting the 'tcib' requirement.

    Change-Id: Iad987da5bedc30da7118a3aec5dbe96cd8d71d1e
    Closes-Bug: #1897616

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/755388

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/755389

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/ussuri)

Reviewed: https://review.opendev.org/755388
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=92654c55ff52b89188c5fb8e8f7fcba4c37bc6dd
Submitter: Zuul
Branch: stable/ussuri

commit 92654c55ff52b89188c5fb8e8f7fcba4c37bc6dd
Author: Alex Schultz <email address hidden>
Date: Mon Sep 28 12:18:17 2020 -0600

    Fix tcib build

    The tcib build process assumes that all the container configs exist in a
    'tcib' folder as defined via --config-path. This change documents this
    requirement and additionally we've hard coded 'container-images' in
    the image config to exclude this folder however if you define a
    custom --config-path, this fails. This change removes the hard coded
    'container-images' while documenting the 'tcib' requirement.

    Change-Id: Iad987da5bedc30da7118a3aec5dbe96cd8d71d1e
    Closes-Bug: #1897616
    (cherry picked from commit fe7380ddff866aec9344ec3fafc3a9a2c255d445)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/755389
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7700507fc7c2bdfab9a1c31ee2f8ce5ca1e55813
Submitter: Zuul
Branch: stable/train

commit 7700507fc7c2bdfab9a1c31ee2f8ce5ca1e55813
Author: Alex Schultz <email address hidden>
Date: Mon Sep 28 12:18:17 2020 -0600

    Fix tcib build

    The tcib build process assumes that all the container configs exist in a
    'tcib' folder as defined via --config-path. This change documents this
    requirement and additionally we've hard coded 'container-images' in
    the image config to exclude this folder however if you define a
    custom --config-path, this fails. This change removes the hard coded
    'container-images' while documenting the 'tcib' requirement.

    Change-Id: Iad987da5bedc30da7118a3aec5dbe96cd8d71d1e
    Closes-Bug: #1897616
    (cherry picked from commit fe7380ddff866aec9344ec3fafc3a9a2c255d445)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.4.0

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.