tripleo_puppet_cache role fails with dcn

[John Fulton]

When deploying a DCN site after deploying the control-plane [1] the first task "Gather variables for each operating system" fails in the role tripleo_puppet_cache fails with:

2020-09-22 13:09:04,006 p=589658 u=stack n=ansible | 2020-09-22 13:09:04.006871 | 244201f5-c182-0458-66e3-0000000003d4 | FATAL | Gather variables for each operating system | dcn0-distributedcomputehci-0 | error={"msg": "No file was found when using first_found. Use errors='ignore' to allow this task to be skipped if no files are found"}

More logs at [3]

[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/features/distributed_compute_node.html#deploying-a-dcn-site

[2] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/roles/tripleo_puppet_cache/tasks/main.yml#L21

[3] http://paste.openstack.org/show/798206/

[Alex Schultz (alex-schultz)]

sounds like the ansible facts weren't properly gathered. I don't think this is a bug with that role

[John Fulton (jfulton-org)]

This bug was user error on my part.
I am running into a bug during DCN deployment, but it's not this one.
I thought I reprouced that bug but I was mistaken and had simply not gathered my facts.
I can avoid this error when using ansible-playbook-command.sh with "--tags facts"

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/753534

[Bogdan Dobrelya (bogdando)]

What are the patterns to use --tags facts or not? Shall the documentation be updated as well?

[John Fulton (jfulton-org)]

The docs [1] cover "tags: facts" for fact gathering for undercloud and overcloud nodes.

I had hit this bug because I ran the ansible playbook with certain tags (to skip things) but didn't include the facts tag. When I added it things worked fine. I didn't hit this bug when I did a standard 'openstack overcloud deploy ...'. I thought I did at first but I was hitting a different issue. That's why I didn't think this was an actual bug.

[1] https://docs.openstack.org/project-deploy-guide/tripleo-docs/latest/deployment/ansible_config_download.html#deploy-steps-playbook-yaml

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/753534
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d9ed99b5d988908bae5a49e27447d7782b23d2d5
Submitter: Zuul
Branch: master

commit d9ed99b5d988908bae5a49e27447d7782b23d2d5
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Sep 23 09:13:24 2020 +0200

    Clear cached facts based on the tag as well

    Facts gathering comes next after clearing the cached ones. Facts
    will be gathered if --tags facts was specified. But cached facts get
    cleared always, even w/o that tag.

    In DCN deployments that may bring errors that can be avoided with
    ansible-playbook-command.sh --tags facts. That is because fact caching
    needs to be updated when running outside of the overcloud.

    Fix this inconsistency so that the facts never cleared nor gathered
    until the facts tag has been used explicitly.

    Change-Id: I0ef544a18ec868321ebf51a99051b1ed982cd677
    Related-bug: #1896620
    Related-bug: #1884654
    Signed-off-by: Bogdan Dobrelya <email address hidden>

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/753807

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/753808

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/753807
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b09c769a73fc6bdd470109e0258635d1eff302be
Submitter: Zuul
Branch: stable/ussuri

commit b09c769a73fc6bdd470109e0258635d1eff302be
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Sep 23 09:13:24 2020 +0200

    Clear cached facts based on the tag as well

    Facts gathering comes next after clearing the cached ones. Facts
    will be gathered if --tags facts was specified. But cached facts get
    cleared always, even w/o that tag.

    In DCN deployments that may bring errors that can be avoided with
    ansible-playbook-command.sh --tags facts. That is because fact caching
    needs to be updated when running outside of the overcloud.

    Fix this inconsistency so that the facts never cleared nor gathered
    until the facts tag has been used explicitly.

    Change-Id: I0ef544a18ec868321ebf51a99051b1ed982cd677
    Related-bug: #1896620
    Related-bug: #1884654
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit d9ed99b5d988908bae5a49e27447d7782b23d2d5)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/753808
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=15ffac7fa04d9b78e46156babe797a3353b209a6
Submitter: Zuul
Branch: stable/train

commit 15ffac7fa04d9b78e46156babe797a3353b209a6
Author: Bogdan Dobrelya <email address hidden>
Date: Wed Sep 23 09:13:24 2020 +0200

    Clear cached facts based on the tag as well

    Facts gathering comes next after clearing the cached ones. Facts
    will be gathered if --tags facts was specified. But cached facts get
    cleared always, even w/o that tag.

    In DCN deployments that may bring errors that can be avoided with
    ansible-playbook-command.sh --tags facts. That is because fact caching
    needs to be updated when running outside of the overcloud.

    Fix this inconsistency so that the facts never cleared nor gathered
    until the facts tag has been used explicitly.

    Change-Id: I0ef544a18ec868321ebf51a99051b1ed982cd677
    Related-bug: #1896620
    Related-bug: #1884654
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit d9ed99b5d988908bae5a49e27447d7782b23d2d5)