if you use :latest for as a tag for containers, they are not rebuilt if the container is updated
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
High
|
Alex Schultz |
Bug Description
If you use latest as the tag, the containers are fetched but they are not rebuilt to use the new container image. The old containers remain in place using the previous version of the container image. I haven't checked if the ansible managed containers still suffer from this problem, but the paunch managed containers do.
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/queens) | #1 |
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/queens) | #2 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit be9f6a3c46f53e8
Author: Alex Schultz <email address hidden>
Date: Thu Sep 17 13:19:35 2020 -0600
Trigger container update on image id update
NOTE: Adapted to queens due to missing backports in rocky.
If you reuse a container tag for a new image, paunch does not currently
rebuild the container to get the new image. This change adds logic to
the updated check to also check the image id defined in the container
instance against the image id for the image to see if the container
image has changed.
Closes-Bug: #1895974
Change-Id: I2710497282eb4d
(cherry picked from commit 4ae7d886db604f1
tags: | added: in-stable-queens |
tags: | added: in-stable-ussuri |
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/ussuri) | #3 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/ussuri
commit 4ae7d886db604f1
Author: Alex Schultz <email address hidden>
Date: Wed Sep 16 14:08:28 2020 -0600
Trigger container update on image id update
If you reuse a container tag for a new image, paunch does not currently
rebuild the container to get the new image. This change adds logic to
the updated check to also check the image id defined in the container
instance against the image id for the image to see if the container
image has changed.
Closes-Bug: #1895974
Change-Id: I2710497282eb4d
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/train) | #4 |
Fix proposed to branch: stable/train
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/stein) | #5 |
Fix proposed to branch: stable/stein
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/rocky) | #6 |
Fix proposed to branch: stable/rocky
Review: https:/
Changed in tripleo: | |
importance: | Undecided → High |
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (master) | #7 |
Related fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master) | #8 |
Fix proposed to branch: master
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to paunch (stable/queens) | #9 |
Fix proposed to branch: stable/queens
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/train) | #10 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/train
commit 0cad8b341954ae7
Author: Alex Schultz <email address hidden>
Date: Wed Sep 16 14:08:28 2020 -0600
Trigger container update on image id update
If you reuse a container tag for a new image, paunch does not currently
rebuild the container to get the new image. This change adds logic to
the updated check to also check the image id defined in the container
instance against the image id for the image to see if the container
image has changed.
Closes-Bug: #1895974
Change-Id: I2710497282eb4d
(cherry picked from commit 4ae7d886db604f1
tags: | added: in-stable-train |
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/rocky) | #11 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/rocky
commit 7779c4bc40016df
Author: Alex Schultz <email address hidden>
Date: Thu Sep 17 13:19:35 2020 -0600
[ROCKY-Only] Trigger container update on image id update
NOTE: Rocky is missing a few backports so this patch is rocky specific.
If you reuse a container tag for a new image, paunch does not currently
rebuild the container to get the new image. This change adds logic to
the updated check to also check the image id defined in the container
instance against the image id for the image to see if the container
image has changed.
Closes-Bug: #1895974
Change-Id: I2710497282eb4d
(cherry picked from commit 4ae7d886db604f1
tags: | added: in-stable-rocky |
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/queens) | #12 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/queens
commit e2306816b1e0efa
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 10:13:17 2020 -0600
[QUEENS Only] Always do a image pull
In queens we use paunch to manage the images and containers. Container
images are not updated if the image has changed but the container tag
has not because we simply check if the container exists on disk. This
change drops the exists check and just issues a pull for all containers
to ensure they are up to date. In newer versions we always pre-fetch the
containers as part of the deployment so we don't need to do this
image management in paunch (or ansible).
Change-Id: Icb5b949c0d9cd4
Closes-Bug: #1895974
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (master) | #13 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 804d0ae51e83600
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 09:23:45 2020 -0600
Add image id compare
If the image has been updated on disk, the podman_container isn't
rebuild to use the new container. This change adds an image id check to
the image check to see if the image name and tag are the same but the id
of the image has changed. It should be noted that the podman_container
does not fetch the updated image as it simply checks if it exists. A
user needs to use podman_image with force: True prior to running
podman_
Change-Id: Icb718d1c1ea9b8
Related-Bug: #1895974
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (stable/ussuri) | #14 |
Related fix proposed to branch: stable/ussuri
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-ansible (stable/train) | #15 |
Related fix proposed to branch: stable/train
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master) | #16 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 920c04bab8cb8e3
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 09:26:00 2020 -0600
Force container fetch
If a user uses :latest, the container is not updated when running the
podman_image nor is it updated by podman_container. Since
podman_
need to force the container pull here to ensure we get updated
containers as part of our deployment and updates processes.
Depends-On: https:/
Change-Id: Ia16cee016fb1af
Closes-Bug: #1895974
Changed in tripleo: | |
status: | In Progress → Fix Released |
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ussuri) | #17 |
Fix proposed to branch: stable/ussuri
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train) | #18 |
Fix proposed to branch: stable/train
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (stable/ussuri) | #19 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/ussuri
commit de51462d23eea30
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 09:23:45 2020 -0600
Add image id compare
If the image has been updated on disk, the podman_container isn't
rebuild to use the new container. This change adds an image id check to
the image check to see if the image name and tag are the same but the id
of the image has changed. It should be noted that the podman_container
does not fetch the updated image as it simply checks if it exists. A
user needs to use podman_image with force: True prior to running
podman_
Change-Id: Icb718d1c1ea9b8
Related-Bug: #1895974
(cherry picked from commit 804d0ae51e83600
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-ansible (stable/train) | #20 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/train
commit aad08b2688edf1b
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 09:23:45 2020 -0600
Add image id compare
If the image has been updated on disk, the podman_container isn't
rebuild to use the new container. This change adds an image id check to
the image check to see if the image name and tag are the same but the id
of the image has changed. It should be noted that the podman_container
does not fetch the updated image as it simply checks if it exists. A
user needs to use podman_image with force: True prior to running
podman_
Change-Id: Icb718d1c1ea9b8
Related-Bug: #1895974
(cherry picked from commit 804d0ae51e83600
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train) | #21 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/train
commit 114c9551bf7c49f
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 09:26:00 2020 -0600
Force container fetch
If a user uses :latest, the container is not updated when running the
podman_image nor is it updated by podman_container. Since
podman_
need to force the container pull here to ensure we get updated
containers as part of our deployment and updates processes.
Depends-On: https:/
Change-Id: Ia16cee016fb1af
Closes-Bug: #1895974
(cherry picked from commit 920c04bab8cb8e3
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ussuri) | #22 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/ussuri
commit cd0448f0123337f
Author: Alex Schultz <email address hidden>
Date: Mon Sep 21 09:26:00 2020 -0600
Force container fetch
If a user uses :latest, the container is not updated when running the
podman_image nor is it updated by podman_container. Since
podman_
need to force the container pull here to ensure we get updated
containers as part of our deployment and updates processes.
Depends-On: https:/
Change-Id: Ia16cee016fb1af
Closes-Bug: #1895974
(cherry picked from commit 920c04bab8cb8e3
OpenStack Infra (hudson-openstack) wrote : Fix merged to paunch (stable/stein) | #23 |
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: stable/stein
commit 6b64778ecfbf2c7
Author: Alex Schultz <email address hidden>
Date: Wed Sep 16 14:08:28 2020 -0600
Trigger container update on image id update
If you reuse a container tag for a new image, paunch does not currently
rebuild the container to get the new image. This change adds logic to
the updated check to also check the image id defined in the container
instance against the image id for the image to see if the container
image has changed.
Closes-Bug: #1895974
Change-Id: I2710497282eb4d
(cherry picked from commit 4ae7d886db604f1
tags: | added: in-stable-stein |
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch 5.4.0 | #24 |
This issue was fixed in the openstack/paunch 5.4.0 release.
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0 | #25 |
This issue was fixed in the openstack/
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch rocky-eol | #26 |
This issue was fixed in the openstack/paunch rocky-eol release.
OpenStack Infra (hudson-openstack) wrote : Change abandoned on paunch (stable/rocky) | #27 |
Change abandoned by "Alex Schultz <email address hidden>" on branch: stable/rocky
Review: https:/
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch queens-eol | #28 |
This issue was fixed in the openstack/paunch queens-eol release.
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/paunch stein-eol | #30 |
This issue was fixed in the openstack/paunch stein-eol release.
Fix proposed to branch: stable/queens /review. opendev. org/752569
Review: https:/