Base subnet is assigned for nodes in leaf networks when spine-leaf environment with assigning predictable IPs.

Bug #1895899 reported by Harald Jensås
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Rabi Mishra

Bug Description

The workaround of this is specifying ip_netmask like below instead of "get_param: InternalApiIpSubnet" in nic-configs.

nic-configs for leaf1 nodes:
```
                  addresses:
                  - ip_netmask: "{{ internal_api_ip ~ '/25' }}"
                      #get_param: InternalApiIpSubnet
```

This broke with: https://review.opendev.org/677218, prior to that groupvars for each role did have the CIDR pulled from the neutron port created by the role template.

Revision history for this message
Harald Jensås (harald-jensas) wrote :
Changed in tripleo:
assignee: nobody → Harald Jensås (harald-jensas)
status: Confirmed → In Progress
Revision history for this message
Harald Jensås (harald-jensas) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/752349

Changed in tripleo:
assignee: Harald Jensås (harald-jensas) → Rabi Mishra (rabi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Harald Jensås (<email address hidden>) on branch: master
Review: https://review.opendev.org/752349
Reason: Discussed with Rabi, and we conclude to go with https://review.opendev.org/750130 instead of this revert.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/750130
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=cd53ae79c79650c4ad1e774dad0bce60a3078c69
Submitter: Zuul
Branch: master

commit cd53ae79c79650c4ad1e774dad0bce60a3078c69
Author: Harald Jensås <email address hidden>
Date: Thu Sep 17 01:02:30 2020 +0200

    Get the CIDR of the neutron port for NetworkConfig

    Since GroupVars moved to overcloud.j2.yaml in
    https://review.opendev.org/677218 the CIDR set in
    '{{network.name_lower}}_cidr' in groupvars is limited
    to one of the subnets on the network.

    When a network have multiple subnets with different
    subnet prefixes, this becomes a problem as nodes are
    configured with the from subnet mask.

    This change moves them to AnsibleHostVars.

    Closes-Bug: #1895899
    Change-Id: I4e4e5b1195d17f59c825a3f7df73920921e1f86e

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/753258

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/753259

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ussuri)

Reviewed: https://review.opendev.org/753258
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3752f15cd08624934ae44c628a28e19c5380aaec
Submitter: Zuul
Branch: stable/ussuri

commit 3752f15cd08624934ae44c628a28e19c5380aaec
Author: Harald Jensås <email address hidden>
Date: Thu Sep 17 01:02:30 2020 +0200

    Get the CIDR of the neutron port for NetworkConfig

    Since GroupVars moved to overcloud.j2.yaml in
    https://review.opendev.org/677218 the CIDR set in
    '{{network.name_lower}}_cidr' in groupvars is limited
    to one of the subnets on the network.

    When a network have multiple subnets with different
    subnet prefixes, this becomes a problem as nodes are
    configured with the from subnet mask.

    This change moves them to AnsibleHostVars.

    Closes-Bug: #1895899
    Change-Id: I4e4e5b1195d17f59c825a3f7df73920921e1f86e
    (cherry picked from commit cd53ae79c79650c4ad1e774dad0bce60a3078c69)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/753259
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5a7f9e14d0ee9bb5c7949a339137778b7ea0c470
Submitter: Zuul
Branch: stable/train

commit 5a7f9e14d0ee9bb5c7949a339137778b7ea0c470
Author: Harald Jensås <email address hidden>
Date: Thu Sep 17 01:02:30 2020 +0200

    Get the CIDR of the neutron port for NetworkConfig

    Since GroupVars moved to overcloud.j2.yaml in
    https://review.opendev.org/677218 the CIDR set in
    '{{network.name_lower}}_cidr' in groupvars is limited
    to one of the subnets on the network.

    When a network have multiple subnets with different
    subnet prefixes, this becomes a problem as nodes are
    configured with the from subnet mask.

    This change moves them to AnsibleHostVars.

    Closes-Bug: #1895899
    Change-Id: I4e4e5b1195d17f59c825a3f7df73920921e1f86e
    (cherry picked from commit cd53ae79c79650c4ad1e774dad0bce60a3078c69)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.