puppet-openstack-unit-6.14-centos-8 failes because of duplicated selinux_core in Puppetfile

[Takashi Kajinami]

Currently unit tests for puppet-tripleo is failing during installing modules.

2020-09-09 08:39:58.025094 | centos-8 | --------------------------------------------------------------------------------

2020-09-09 08:39:58.025160 | centos-8 | | Install Modules |

2020-09-09 08:39:58.025296 | centos-8 | --------------------------------------------------------------------------------

2020-09-09 08:39:58.025410 | centos-8 | + install_modules_unit

2020-09-09 08:39:58.025474 | centos-8 | + '[' -d /home/zuul/src/opendev.org ']'

2020-09-09 08:39:58.025610 | centos-8 | + csplit /home/zuul/workspace/openstack/puppet-openstack-integration/Puppetfile '/External modules/' --prefix /home/zuul/workspace/openstack/puppet-openstack-integration/Puppetfile --suffix %d

2020-09-09 08:39:58.028408 | centos-8 | 3585

2020-09-09 08:39:58.028445 | centos-8 | 4609

2020-09-09 08:39:58.028718 | centos-8 | + cat /home/zuul/workspace/openstack/puppet-openstack-integration/Puppetfile_unit

2020-09-09 08:39:58.030127 | centos-8 | + install_external

2020-09-09 08:39:58.030272 | centos-8 | + r10k -v DEBUG puppetfile install --puppetfile /home/zuul/workspace/openstack/puppet-openstack-integration/Puppetfile1 --moduledir /home/zuul/workspace/spec/fixtures/modules

2020-09-09 08:39:59.069525 | centos-8 | [2020-09-09 08:39:59 - INFO] Using Puppetfile '/home/zuul/workspace/openstack/puppet-openstack-integration/Puppetfile1'

2020-09-09 08:39:59.077821 | centos-8 | [2020-09-09 08:39:59 - ERROR] Puppetfiles cannot contain duplicate module names. Remove the duplicates of the following modules: selinux_core

2020-09-09 08:39:59.089725 | centos-8 | rake aborted!

2020-09-09 08:39:59.089808 | centos-8 | Command failed with status (1): [env PUPPETFILE_DIR=/home/zuul/workspace/sp...]

https://zuul.opendev.org/t/openstack/build/88b5f57f47b34a38bf5502ddec5c42a4/log/job-output.txt#1939-1953

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/750628

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/750628
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=39a33dad4d1ed479bcd9680ee0f44dd50d01d5fc
Submitter: Zuul
Branch: master

commit 39a33dad4d1ed479bcd9680ee0f44dd50d01d5fc
Author: Takashi Kajinami <email address hidden>
Date: Wed Sep 9 20:34:53 2020 +0900

    Resolve conflict during module installation for unit tests

    Since the change[1] in p-o-i is merged, selinux_core is automatically
    installed during unit test and inistallation of modules fails if we
    have the same module included in Puppet_extras file.

    This patch removes selinux_core from Puppet_extras because for
    the current CI jobs of puppet-tripleo it's enough if the package is
    somehow installed during unit tests.

    [1] ef3c5dc9b7294b38b95c4e900bd142987472f976

    Closes-Bug: #1894984
    Change-Id: I15e541a641969af7ac117faf13d67827662e7ca6