python-tripleoclient - tox-py27 stable/train broken

[Cédric Jeanneret]

Hello,

Apparently something broke python-tripleoclient on train:

2020-09-08 10:21:38.896364 | ubuntu-bionic | Captured traceback:
2020-09-08 10:21:38.896375 | ubuntu-bionic | ~~~~~~~~~~~~~~~~~~~
2020-09-08 10:21:38.896386 | ubuntu-bionic | Traceback (most recent call last):
2020-09-08 10:21:38.896397 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/python-tripleoclient/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 1330, in patched
2020-09-08 10:21:38.896409 | ubuntu-bionic | return func(*args, **keywargs)
2020-09-08 10:21:38.896420 | ubuntu-bionic | File "tripleoclient/tests/v1/undercloud/test_install_upgrade.py", line 627, in test_undercloud_upgrade_all_opts
2020-09-08 10:21:38.896432 | ubuntu-bionic | '--inflight-validations', '--dry-run', '--yes', '--debug'])
2020-09-08 10:21:38.896444 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/python-tripleoclient/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 296, in assert_called_with
2020-09-08 10:21:38.896463 | ubuntu-bionic | return mock.assert_called_with(*args, **kwargs)
2020-09-08 10:21:38.896477 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/python-tripleoclient/.tox/py27/lib/python2.7/site-packages/mock/mock.py", line 944, in assert_called_with
2020-09-08 10:21:38.896489 | ubuntu-bionic | six.raise_from(AssertionError(_error_message(cause)), cause)
2020-09-08 10:21:38.896500 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/python-tripleoclient/.tox/py27/lib/python2.7/site-packages/six.py", line 737, in raise_from
2020-09-08 10:21:38.896511 | ubuntu-bionic | raise value
2020-09-08 10:21:38.896523 | ubuntu-bionic | AssertionError: expected call not found.
2020-09-08 10:21:38.896534 | ubuntu-bionic | Expected: check_call(['openstack', 'undercloud', 'upgrade', '--skip-package-updates', '--force-stack-update', '--no-validations', '--inflight-validations', '--dry-run', '--yes', '--debug'])
2020-09-08 10:21:38.896547 | ubuntu-bionic | Actual: check_call(['openstack', 'undercloud', 'upgrade', '--skip-package-updates', '--yes', '--inflight-validations', '--no-validations', '--dry-run', '--force-stack-update', '--debug'])

We can see it in this (unrelated) change:
https://review.opendev.org/#/c/750211/

Full log:
https://59528cbb535c9387d6c8-29c5fbc03cde99e5a6a999f93f05d2d6.ssl.cf5.rackcdn.com/750211/1/check/openstack-tox-py27/6e90860/job-output.txt

https://59528cbb535c9387d6c8-29c5fbc03cde99e5a6a999f93f05d2d6.ssl.cf5.rackcdn.com/750211/1/check/openstack-tox-py27/6e90860/testr_results.html

[Cédric Jeanneret (cjeanner)]

Not as nasty as I thought, that job is non-voting.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/751071

[OpenStack Infra (hudson-openstack)]

Change abandoned by "James Slagle <email address hidden>" on branch: stable/train
Review: https://review.opendev.org/c/openstack/python-tripleoclient/+/751071
Reason: Abandoning this patch per the TripleO Patch Abandonment guidelines
(https://specs.openstack.org/openstack/tripleo-specs/specs/policy/patch-abandonment.html).
If you wish to have this restored and cannot do so yourself, please reach out
via #tripleo on OFTC or the OpenStack Dev mailing list.