ovn-dbs update task fails on bootstrap node 'ovn_dbs_image_latest' is undefined

[Michele Baldessari]

I was testing a minor update on master and noticed the following error on the ovn-dbs bootstrap node (controller-0):
2020-08-18 07:16:16.346959 | 00a673e5-dc44-c6b1-ce2d-000000000094 |
FATAL | Update the ovn-dbs-bundle to use the new container image name | overcloud-controller-0 | error={"msg": "The conditional check
'ovn_dbs_current_image.stdout != ovn_dbs_image_latest' failed. The error was: error while evaluating conditional (ovn_dbs_current_image.stdout !=
ovn_dbs_image_latest): 'ovn_dbs_image_latest' is undefined\n\nThe error appears to be in '/tmp/tripleo5rvsi_ix/overcloud/Controller/update_tasks_step5.yaml':
line 23, column 7, but may\nbe elsewhere in the file depending on the
exact syntax problem.\n\nThe offending line appears to be:\n\n - block:\n - command: pcs resource bundle update ovn-dbs-bundle
container image={{ovn_dbs_image_latest}}\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing
quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be
written as:\n\n with_items:\n - \"{{ foo }}\"\n"}

The task 'Update the ovn-dbs-bundle to use the new container image name' is indeed missing the variable and needs fixing.

[Michele Baldessari (michele)]

https://review.opendev.org/740173

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746651
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e892d40046253830c4ef28e4f5fae8235cabcab8
Submitter: Zuul
Branch: master

commit e892d40046253830c4ef28e4f5fae8235cabcab8
Author: Michele Baldessari <email address hidden>
Date: Tue Aug 18 09:58:18 2020 +0200

    Fix up ovn-dbs update tasks

    Noticed master failing with:
    2020-08-18 07:16:16.346959 | 00a673e5-dc44-c6b1-ce2d-000000000094 |
    FATAL | Update the ovn-dbs-bundle to use the new container image name | overcloud-controller-0 | error={"msg": "The conditional check
    'ovn_dbs_current_image.stdout != ovn_dbs_image_latest' failed. The error was: error while evaluating conditional (ovn_dbs_current_image.stdout !=
    ovn_dbs_image_latest): 'ovn_dbs_image_latest' is undefined\n\nThe error appears to be in '/tmp/tripleo5rvsi_ix/overcloud/Controller/update_tasks_step5.yaml':
    line 23, column 7, but may\nbe elsewhere in the file depending on the
    exact syntax problem.\n\nThe offending line appears to be:\n\n - block:\n - command: pcs resource bundle update ovn-dbs-bundle
    container image={{ovn_dbs_image_latest}}\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing
    quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be
    written as:\n\n with_items:\n - \"{{ foo }}\"\n"}

    Tested a minor update with this patch and I did not hit the error
    anymore.

    Closes-Bug: #1892042

    Change-Id: I875a0753686669b16d0ceb25e6e5692c150d6a79

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/747456

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/747515

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747456
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3ce68de0f895eed6a2dfb34700f692d34d1aedc3
Submitter: Zuul
Branch: stable/ussuri

commit 3ce68de0f895eed6a2dfb34700f692d34d1aedc3
Author: Michele Baldessari <email address hidden>
Date: Tue Aug 18 09:58:18 2020 +0200

    Fix up ovn-dbs update tasks

    Noticed master failing with:
    2020-08-18 07:16:16.346959 | 00a673e5-dc44-c6b1-ce2d-000000000094 |
    FATAL | Update the ovn-dbs-bundle to use the new container image name | overcloud-controller-0 | error={"msg": "The conditional check
    'ovn_dbs_current_image.stdout != ovn_dbs_image_latest' failed. The error was: error while evaluating conditional (ovn_dbs_current_image.stdout !=
    ovn_dbs_image_latest): 'ovn_dbs_image_latest' is undefined\n\nThe error appears to be in '/tmp/tripleo5rvsi_ix/overcloud/Controller/update_tasks_step5.yaml':
    line 23, column 7, but may\nbe elsewhere in the file depending on the
    exact syntax problem.\n\nThe offending line appears to be:\n\n - block:\n - command: pcs resource bundle update ovn-dbs-bundle
    container image={{ovn_dbs_image_latest}}\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing
    quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be
    written as:\n\n with_items:\n - \"{{ foo }}\"\n"}

    Tested a minor update with this patch and I did not hit the error
    anymore.

    Closes-Bug: #1892042

    Change-Id: I875a0753686669b16d0ceb25e6e5692c150d6a79
    (cherry picked from commit e892d40046253830c4ef28e4f5fae8235cabcab8)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/747515
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=41d5a77cfaca4db1818981ea6d016e86c607fdc8
Submitter: Zuul
Branch: stable/train

commit 41d5a77cfaca4db1818981ea6d016e86c607fdc8
Author: Michele Baldessari <email address hidden>
Date: Tue Aug 18 09:58:18 2020 +0200

    Fix up ovn-dbs update tasks

    Noticed master failing with:
    2020-08-18 07:16:16.346959 | 00a673e5-dc44-c6b1-ce2d-000000000094 |
    FATAL | Update the ovn-dbs-bundle to use the new container image name | overcloud-controller-0 | error={"msg": "The conditional check
    'ovn_dbs_current_image.stdout != ovn_dbs_image_latest' failed. The error was: error while evaluating conditional (ovn_dbs_current_image.stdout !=
    ovn_dbs_image_latest): 'ovn_dbs_image_latest' is undefined\n\nThe error appears to be in '/tmp/tripleo5rvsi_ix/overcloud/Controller/update_tasks_step5.yaml':
    line 23, column 7, but may\nbe elsewhere in the file depending on the
    exact syntax problem.\n\nThe offending line appears to be:\n\n - block:\n - command: pcs resource bundle update ovn-dbs-bundle
    container image={{ovn_dbs_image_latest}}\n ^ here\nWe could be wrong, but this one looks like it might be an issue with\nmissing
    quotes. Always quote template expression brackets when they\nstart a value. For instance:\n\n with_items:\n - {{ foo }}\n\nShould be
    written as:\n\n with_items:\n - \"{{ foo }}\"\n"}

    Tested a minor update with this patch and I did not hit the error
    anymore.

    Closes-Bug: #1892042

    Change-Id: I875a0753686669b16d0ceb25e6e5692c150d6a79
    (cherry picked from commit e892d40046253830c4ef28e4f5fae8235cabcab8)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.