openstack overcloud export always uses "passwords" from plan-environment.yaml

[James Slagle]

The "passwords" key from plan-environment.yaml is actually the generated passwords. This results in openstack overcloud export always exporting the generated passwords instead of any user specified ones.

The export command needs to look at parameter_defaults from plan-environment.yaml to get the user defined values, and fall back to passwords if none was specified.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/745958

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745958
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=ced221406b70c348453c82247c9274fb11c77dd3
Submitter: Zuul
Branch: master

commit ced221406b70c348453c82247c9274fb11c77dd3
Author: James Slagle <email address hidden>
Date: Wed Aug 12 16:07:03 2020 -0400

    Use user set password values in overcloud export

    The overcloud export command needs to look at both the
    parameter_defaults and passwords keys from plan-environment.yaml.
    passwords contains only the generated password values, while
    parameter_defaults contains any user set values. If a value is not set
    in parameter_defaults, then passwords can be used.

    Change-Id: I6b1b8bd1e7800720f6bbbe418c1f83b2f710fb48
    Closes-Bug: #1891388
    Signed-off-by: James Slagle <email address hidden>

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/746143

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/746160

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746143
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=31aeb48e7063d32f83d903a3a0eb8d287f76a861
Submitter: Zuul
Branch: stable/ussuri

commit 31aeb48e7063d32f83d903a3a0eb8d287f76a861
Author: James Slagle <email address hidden>
Date: Wed Aug 12 16:07:03 2020 -0400

    Use user set password values in overcloud export

    The overcloud export command needs to look at both the
    parameter_defaults and passwords keys from plan-environment.yaml.
    passwords contains only the generated password values, while
    parameter_defaults contains any user set values. If a value is not set
    in parameter_defaults, then passwords can be used.

    Change-Id: I6b1b8bd1e7800720f6bbbe418c1f83b2f710fb48
    Closes-Bug: #1891388
    Signed-off-by: James Slagle <email address hidden>
    (cherry picked from commit ced221406b70c348453c82247c9274fb11c77dd3)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746160
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c15d0d0ba0b3de7e78a9d9a4b1c88b8f497b97df
Submitter: Zuul
Branch: stable/train

commit c15d0d0ba0b3de7e78a9d9a4b1c88b8f497b97df
Author: James Slagle <email address hidden>
Date: Wed Aug 12 16:07:03 2020 -0400

    Use user set password values in overcloud export

    The overcloud export command needs to look at both the
    parameter_defaults and passwords keys from plan-environment.yaml.
    passwords contains only the generated password values, while
    parameter_defaults contains any user set values. If a value is not set
    in parameter_defaults, then passwords can be used.

    Change-Id: I6b1b8bd1e7800720f6bbbe418c1f83b2f710fb48
    Closes-Bug: #1891388
    Signed-off-by: James Slagle <email address hidden>
    (cherry picked from commit ced221406b70c348453c82247c9274fb11c77dd3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.