[RHOSP 13 to 16.1 Upgrades][SRIOV] Baremetal node hangs on reboot during leapp upgrade

[Saravanan KR]

With SR-IOV VF interfaces enabled, leapp upgrade hangs on reboot.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/745280

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/745874

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/745875

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745280
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b3ec034649e0d18de78fcfe5f903cfe9a0a18a6a
Submitter: Zuul
Branch: master

commit b3ec034649e0d18de78fcfe5f903cfe9a0a18a6a
Author: Saravanan KR <email address hidden>
Date: Fri Aug 7 09:33:30 2020 +0530

    Reset sriov_numvfs to 0 before leapp upgrade

    Leapp's actor persistentnetnamesconfig will try
    to apply the nic names based on the mac address.
    Whlie collecting the data, leapp will also add the
    VFs details to RHEL7 catalog (leapp.db). But when
    RHEL8 ramfs boots, it will not find the VF interfaces.
    VFs will be configured using sriov_config service
    on boot (not applied during upgrade). Remove VFs
    before leapp upgrade as a workaround.
    Closes-Bug: #1890769

    Change-Id: I5054d5970e6c88cf3cdcd9c3850ef926040bc827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745874
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=00850a30ae2b5a074d48bd60e9412e0f4104af44
Submitter: Zuul
Branch: stable/ussuri

commit 00850a30ae2b5a074d48bd60e9412e0f4104af44
Author: Saravanan KR <email address hidden>
Date: Fri Aug 7 09:33:30 2020 +0530

    Reset sriov_numvfs to 0 before leapp upgrade

    Leapp's actor persistentnetnamesconfig will try
    to apply the nic names based on the mac address.
    Whlie collecting the data, leapp will also add the
    VFs details to RHEL7 catalog (leapp.db). But when
    RHEL8 ramfs boots, it will not find the VF interfaces.
    VFs will be configured using sriov_config service
    on boot (not applied during upgrade). Remove VFs
    before leapp upgrade as a workaround.
    Closes-Bug: #1890769

    Change-Id: I5054d5970e6c88cf3cdcd9c3850ef926040bc827
    (cherry picked from commit b3ec034649e0d18de78fcfe5f903cfe9a0a18a6a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/745875
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=855379056d1650560cb8d92eb70562218d25f149
Submitter: Zuul
Branch: stable/train

commit 855379056d1650560cb8d92eb70562218d25f149
Author: Saravanan KR <email address hidden>
Date: Fri Aug 7 09:33:30 2020 +0530

    Reset sriov_numvfs to 0 before leapp upgrade

    Leapp's actor persistentnetnamesconfig will try
    to apply the nic names based on the mac address.
    Whlie collecting the data, leapp will also add the
    VFs details to RHEL7 catalog (leapp.db). But when
    RHEL8 ramfs boots, it will not find the VF interfaces.
    VFs will be configured using sriov_config service
    on boot (not applied during upgrade). Remove VFs
    before leapp upgrade as a workaround.
    Closes-Bug: #1890769

    Change-Id: I5054d5970e6c88cf3cdcd9c3850ef926040bc827

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/746917
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=e0ece7e5a3ea3fc3b451963a7bab4ae0ece12600
Submitter: Zuul
Branch: master

commit e0ece7e5a3ea3fc3b451963a7bab4ae0ece12600
Author: Saravanan KR <email address hidden>
Date: Wed Aug 19 18:26:31 2020 +0530

    Update kernel args grub file entry inline with upgrade changes

    For FFU, leapp tool requires the /etc/default/grub file
    to have entries to start with "GRUB". upgrade_steps for
    ffu has been updated to fix it for FFU. Align the args
    with the same name for the fresh deployment too.

    Related-Bug: #1890769
    Change-Id: I2349f30d2159e068ebdb453372050459b7a78c65

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/753206

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/753207

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/753206
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=802cdc063003bc9f350af5723912b7742713fe0a
Submitter: Zuul
Branch: stable/ussuri

commit 802cdc063003bc9f350af5723912b7742713fe0a
Author: Saravanan KR <email address hidden>
Date: Wed Aug 19 18:26:31 2020 +0530

    Update kernel args grub file entry inline with upgrade changes

    For FFU, leapp tool requires the /etc/default/grub file
    to have entries to start with "GRUB". upgrade_steps for
    ffu has been updated to fix it for FFU. Align the args
    with the same name for the fresh deployment too.

    Related-Bug: #1890769
    Change-Id: I2349f30d2159e068ebdb453372050459b7a78c65
    (cherry picked from commit e0ece7e5a3ea3fc3b451963a7bab4ae0ece12600)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.