tox-tht in tht doesn't take into accout depends-on on tripleo-ansible.

Bug #1889209 reported by Sofer Athlan-Guyot
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
In Progress
Critical
Unassigned

Bug Description

Hi,

testing a new ansible module in tht doesn't work[1]

[0;31mfatal: [localhost]: FAILED! => {"reason": "couldn't resolve module/action 'tripleo_ovs_upgrade'. This often indicates a misspelling, missing collection, or incorrect module path.\n\nThe error appears to be in '/home/zuul/src/opendev.org/openstack/tht-rendered/rendered-tasks/overcloud-resource-registry-puppet_upgrade_tasks.yml': line 1349, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 0\n- tripleo_ovs_upgrade: null\n ^ here\n"}
included: /home/zuul/src/opendev.org/openstack/tht-rendered/rendered-tasks/overcloud-resource-registry-puppet_post_upgrade_tasks.yml for localhost

Here, I'm testing a new ansible module named tripleo_ovs_upgrade.

In there[2], there's nothing to verify that the depends-on is on tripleo-ansible and then get the patch.

So I'm wondering what is the way to test new module and how to merge the change in tht[3]

[1] https://zuul.opendev.org/t/openstack/build/bf59fd54661e43ac9def6b129493162f
[2] https://opendev.org/openstack/tripleo-heat-templates/src/branch/master/tripleo_heat_templates/tests/tht-role-requirements.yml#L17
[3] The review is https://review.opendev.org/#/c/742632/

Tags: ci
Changed in tripleo:
milestone: victoria-1 → victoria-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/743562

Changed in tripleo:
assignee: nobody → Sorin Sbarnea (ssbarnea)
status: Triaged → In Progress
Revision history for this message
Sofer Athlan-Guyot (sofer-athlan-guyot) wrote :

The above patch isn't enough, I've tested it by rebasing https://review.opendev.org/#/c/742632/ on top of https://review.opendev.org/743562 and the tht patch is still failing for the same reason:

 "couldn't resolve module/action 'tripleo_ovs_upgrade'

in there https://zuul.opendev.org/t/openstack/build/6258dfb813ae4b13ac80c8d0e84e4e34

Revision history for this message
Sofer Athlan-Guyot (sofer-athlan-guyot) wrote :

Note that in the job output I cannot find any special treatment on the depends-on, so not sure using zuul help here, but I may be missing something.

https://zuul.opendev.org/t/openstack/build/6258dfb813ae4b13ac80c8d0e84e4e34/log/job-output.txt

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

AFAIK, dependencies management details can only be taken from zuul executor / scheduler et all "hidden" logs

Revision history for this message
Bogdan Dobrelya (bogdando) wrote :

that's better to ask #zuul ppl

Revision history for this message
Sorin Sbarnea (ssbarnea) wrote :

True, you need to add it to required-projects in order to get it, read https://zuul-ci.org/docs/zuul/reference/jobs.html#git-repositories

If you run this on another host, you will have to deploy (syncrhonize) the code to it.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Sorin Sbarnea (zbr) (<email address hidden>) on branch: master
Review: https://review.opendev.org/743562

Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Sorin Sbarnea (ssbarnea)
Changed in tripleo:
assignee: Sorin Sbarnea (ssbarnea) → nobody
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Changed in tripleo:
milestone: xena-1 → xena-2
Changed in tripleo:
milestone: xena-2 → xena-3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.