[train-only] waiting for ssh to come up during deployment spits ResourceWarnings

[Alex Schultz]

The related code was removed in Ussuri, but train throws resource warnings during the deployment when waiting for the nodes to become available.

/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38280)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:175: ResourceWarning: unclosed <socket.socket fd=9, family=AddressFamily.AF_INET6, type=SocketKind.SOCK_STREAM, proto=0, laddr=('::', 0, 0, 0)>
  sock = socket.socket()
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38598)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38688)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38736)>
  sock = socket.socket(socket.AF_INET6)
/usr/lib/python3.6/site-packages/tripleoclient/workflows/deployment.py:181: ResourceWarning: unclosed <socket.socket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=0, laddr=('0.0.0.0', 38780)>
  sock = socket.socket(socket.AF_INET6)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/742678

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/742678
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=9e08f1ead2988d1bbb54e193bdd7dfd6118b68f3
Submitter: Zuul
Branch: stable/train

commit 9e08f1ead2988d1bbb54e193bdd7dfd6118b68f3
Author: Alex Schultz <email address hidden>
Date: Thu Jul 23 08:04:42 2020 -0600

    [TRAIN-and-older] Properly close sockets

    Currently we properly close the ipv4 socket when we're check for nodes
    to become available. This change adds additional closes to ensure we
    clean up the sockets when we're done with them while we wait.

    Note this code was removed in Ussuri so this is a <= train only patch

    Change-Id: Ie1711972e2fdb2af80b50a2bf514fc46151ae4f3
    Closes-Bug: #1888676

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.