overcloud-hardened-full job is broken with DIB_BLOCK_DEVICE: unbound variable

[chandan kumar]

https://zuul.opendev.org/t/openstack/builds?job_name=tripleo-buildimage-overcloud-hardened-full-centos-8 is broken from July22, 2020 with following error:

https://2b9b7e5c84e3ceae95b6-55de238001b0f469b6551044671dd544.ssl.cf1.rackcdn.com/737682/6/gate/tripleo-buildimage-overcloud-hardened-full-centos-8/80d4daa/overcloud-hardened-full.log

2020-07-23 02:37:35.834 | + install_grub2
2020-07-23 02:37:35.834 | + '[' -f /tmp/grub/install ']'
2020-07-23 02:37:35.834 | + [[ amd64 =~ ppc ]]
2020-07-23 02:37:35.834 | /tmp/in_target.d/finalise.d/50-bootloader: line 65: DIB_BLOCK_DEVICE: unbound variable
2020-07-23 02:37:35.841 | ++ diskimage_builder/lib/img-functions:run_in_target:59 : check_break after-error run_in_target bash
2020-07-23 02:37:35.844 | ++ diskimage_builder/lib/common-functions:check_break:143 : echo ''
2020-07-23 02:37:35.845 | ++ diskimage_builder/lib/common-functions:check_break:143 : egrep -e '(,|^)after-error(,|$)' -q

From gerrit reviews, there is no such changes landed in diskimage-builder. May be it is coming from somewhere else.

Filling this bug as a tracker.

[chandan kumar (chkumar246)]

From successful logs: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b1b/738375/3/check/tripleo-buildimage-overcloud-hardened-full-centos-8/b1b36d4/overcloud-hardened-full.log

++ export DIB_DRACUT_ENABLED_MODULES
2020-07-17 11:10:51.942 | dib-run-parts Sourcing environment file /tmp/in_target.d/pre-install.d/../environment.d/11-dib-install-type.bash
2020-07-17 11:10:51.944 | + source /tmp/in_target.d/pre-install.d/../environment.d/11-dib-install-type.bash
2020-07-17 11:10:51.944 | ++ export DIB_DEFAULT_INSTALLTYPE=package
2020-07-17 11:10:51.944 | ++ DIB_DEFAULT_INSTALLTYPE=package
2020-07-17 11:10:51.944 | dib-run-parts Sourcing environment file /tmp/in_target.d/pre-install.d/../environment.d/11-yum-dnf.bash
2020-07-17 11:10:51.948 | + source /tmp/in_target.d/pre-install.d/../environment.d/11-yum-dnf.bash
2020-07-17 11:10:51.948 | ++ [[ 8 == \8 ]]
2020-07-17 11:10:51.948 | ++ export YUM=dnf
2020-07-17 11:10:51.948 | ++ YUM=dnf
2020-07-17 11:10:51.948 | dib-run-parts Sourcing environment file /tmp/in_target.d/pre-install.d/../environment.d/14-manifests
2020-07-17 11:10:51.951 | + source /tmp/in_target.d/pre-install.d/../environment.d/14-manifests
2020-07-17 11:10:51.951 | ++ export DIB_MANIFEST_IMAGE_DIR=/etc/dib-manifests
2020-07-17 11:10:51.951 | ++ DIB_MANIFEST_IMAGE_DIR=/etc/dib-manifests
2020-07-17 11:10:51.951 | ++ export DIB_MANIFEST_SAVE_DIR=./overcloud-hardened-full.d/
2020-07-17 11:10:51.951 | ++ DIB_MANIFEST_SAVE_DIR=./overcloud-hardened-full.d/
2020-07-17 11:10:51.951 | dib-run-parts Sourcing environment file /tmp/in_target.d/pre-install.d/../environment.d/15-block-device.bash
2020-07-17 11:10:51.953 | + source /tmp/in_target.d/pre-install.d/../environment.d/15-block-device.bash
2020-07-17 11:10:51.953 | ++ [[ arm64 aarch64 =~ amd64 ]]
2020-07-17 11:10:51.953 | ++ export DIB_BLOCK_DEVICE=mbr
2020-07-17 11:10:51.953 | ++ DIB_BLOCK_DEVICE=mbr
2020-07-17 11:10:51.953 | dib-run-parts Sourcing environment file /tmp/in_target.d/pre-install.d/../environment.d/15-pip-manifests
2020-07-17 11:10:51.956 | + source /tmp/in_target.d/pre-install.d/../environment.d/15-pip-manifests
2020-07-17 11:10:51.956 | ++ set -eu
2020-07-17 11:10:51.956 | ++ export DIB_MANIFEST_PIP_DIR=/etc/dib-manifests/dib-manifests-pip
2020-07-17 11:10:51.956 | ++ DIB_MANIFEST_PIP_DIR=/etc/dib-manifests/dib-manifests-pip
2020-07-17 11:10:51.956 | dib-run-parts Sourcing environment file /tmp/in_target.d/pre-install.d/../environment.d/50-dib-python-version

But in failed one:

++ export DIB_DRACUT_ENABLED_MODULES
2020-07-22 07:43:32.107 | dib-run-parts Sourcing environment file /tmp/in_target.d/install.d/../environment.d/11-dib-install-type.bash
2020-07-22 07:43:32.109 | + source /tmp/in_target.d/install.d/../environment.d/11-dib-install-type.bash
2020-07-22 07:43:32.109 | ++ export DIB_DEFAULT_INSTALLTYPE=package
2020-07-22 07:43:32.109 | ++ DIB_DEFAULT_INSTALLTYPE=package
2020-07-22 07:43:32.110 | dib-run-parts Sourcing environment file /tmp/in_target.d/install.d/../environment.d/11-yum-dnf.bash
2020-07-22 07:43:32.112 | + source /tmp/in_target.d/install.d/../environment.d/11-yum-dnf.bash
2020-07-22 07:43:32.112 | ++ [[ 8 ==...

[chandan kumar (chkumar246)]

https://review.opendev.org/#/c/741319/ - Move partition handling to overcloud-partition / overcloud-partition-uefi in tripleo-image-elements might have caused it

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/742645

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/742645
Committed: https://git.openstack.org/cgit/openstack/tripleo-common/commit/?id=8978eef74c633afc9873bfb0c8ddfa6da6c6e364
Submitter: Zuul
Branch: master

commit 8978eef74c633afc9873bfb0c8ddfa6da6c6e364
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Thu Jul 23 17:14:49 2020 +0530

    Replace overcloud-secure with overcloud-partition

    https://review.opendev.org/#/c/741319/ in tripleo-image-elements
    moves partition handling from overcloud-secure to
    overcloud-partition to create whole disk image.

    It breaks the overclodu hardened images jobs with
    DIB_BLOCK_DEVICE: unbound variable.

    By updating the element to overcloud-partition
    fixes the issue.

    It also updates the elements for uefi.

    Closes-Bug: #1888613

    Change-Id: I968e4c52dd0b63e26dd86ff137b0b8f1dfbcb311
    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>

[David Hill (david-hill-ubisoft)]

We might want to add overcloud-secure to remove the unwanted packages such as telnet and kexec-tools...