centos8 master undercloud upgrade failing - yum instead of dnf

[Marios Andreou]

centos8 master undercloud upgrade failing at [1] because it tries to use yum instead of dnf with trace like:

        2020-07-08 14:23:13 | Updating necessary packages: python3-tripleoclient openstack-tripleo-common openstack-tripleo-heat-templates openstack-tripleo-validations tripleo-ansible
        2020-07-08 14:23:13 | Update extra packages failed: b'sudo: yum: command not found\n'
        2020-07-08 14:23:13 | Exception occured while running the command
        2020-07-08 14:23:13 | Traceback (most recent call last):
        2020-07-08 14:23:13 | File "/usr/lib/python3.6/site-packages/tripleoclient/utils.py", line 2053, in run_command

Note this job is new/being re-added in [2].

[1] https://b0dfe17f7f9de783c598-db4d0e167ddaa306c31cbc58181ba1ac.ssl.cf1.rackcdn.com/739218/6/check/tripleo-ci-centos-8-containerized-undercloud-upgrades/dd16c40/logs/undercloud/home/zuul/undercloud_upgrade.log
[2] https://review.opendev.org/#/c/739218/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/740019

[Marios Andreou (marios-b)]

also seen on ussuri so we'll need 740019 in stable/ussuri and train too once it merges

[Marios Andreou (marios-b)]

        * https://f9e8859cf26b7d4481ec-005095c9da7f9886ddbc5e1cb2d2328c.ssl.cf2.rackcdn.com/739457/7/check/tripleo-ci-centos-8-containerized-undercloud-upgrades/09f5ff4/logs/undercloud/home/zuul/undercloud_upgrade.log
        * 2020-07-15 13:56:11 | Update extra packages failed: b'sudo: yum: command not found\n'

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/740019
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=9c53cb3ef5ad513b05d4888552a3280e0eec43ca
Submitter: Zuul
Branch: master

commit 9c53cb3ef5ad513b05d4888552a3280e0eec43ca
Author: Marios Andreou <email address hidden>
Date: Wed Jul 8 18:27:01 2020 +0300

    Fix package manager used during undercloud packages update

    As described in the related bug we need to use dnf instead of yum
    for centos8 otherwise it fails in the undercloud packages update.

    I am using the python version to determine - py3 is dnf. As part of
    discussion here when dnf isn't available fall back to yum.

    Found as part of the work in [1].

    Related-Bug: 1886837
    [1] https://tree.taiga.io/project/tripleo-ci-board/task/1817

    Change-Id: Idac62d37a19ee49f30936e20021a9dab5af40eec

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/741383

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/741383
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=c20dcf9aeab45cd062c5cbe82c9c5baf9dc20684
Submitter: Zuul
Branch: stable/ussuri

commit c20dcf9aeab45cd062c5cbe82c9c5baf9dc20684
Author: Marios Andreou <email address hidden>
Date: Wed Jul 8 18:27:01 2020 +0300

    Fix package manager used during undercloud packages update

    As described in the related bug we need to use dnf instead of yum
    for centos8 otherwise it fails in the undercloud packages update.

    I am using the python version to determine - py3 is dnf. As part of
    discussion here when dnf isn't available fall back to yum.

    Found as part of the work in [1].

    Related-Bug: 1886837
    [1] https://tree.taiga.io/project/tripleo-ci-board/task/1817

    Change-Id: Idac62d37a19ee49f30936e20021a9dab5af40eec
    (cherry picked from commit 9c53cb3ef5ad513b05d4888552a3280e0eec43ca)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/741631

[Marios Andreou (marios-b)]

This merged to stable/ussuri https://review.opendev.org/741383.

I have a cherrypick up for train https://review.opendev.org/741631 BUT I don't think we need that one. We won't have centos8 upgrades jobs for train (for now... this may change TBD possibly centos7 only) so the code shouldn't be exericed by CI in train. I marked the change with -2 for now and should probably abandon it.

Marking the bug as fix-released.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Marios Andreou (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/741631
Reason: https://bugs.launchpad.net/tripleo/+bug/1886837/comments/8