container image prepare assumes default tag of 16.0 always exists even when it doesn't in a filtered content view
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
High
|
Emilien Macchi |
Bug Description
If you don't specify a tag key in ContainerImageP
image_uploader.py will then attempt to load the manifest for the 16.0 tagged image so that tag_from_label can then be used to set the actual tag for the image.
However, when using a filtered content view in Satellite, an image with tag 16.0 may not exist. In that case, you get a not found error similar to:
tripleo_
Adding the 16.0 tag to the content view doesn't work either, then image_uploader.py just looks for the latest tag it read from the label, which likely doesn't exist in the content view either.
The proposed behavior should be something like:
- save somehow if the default value of tag was used
- when _inspect runs in image_uploader.py, if the image is not found, check if the default tag was added and used.
- if it was, then query for the list of tags (this is already done anyway), pick one (sort with vercmp perhaps), and read the manifest from that one.
- use that manifest to read all the labels/etc.
Changed in tripleo: | |
status: | New → In Progress |
importance: | Undecided → High |
assignee: | nobody → James Slagle (james-slagle) |
milestone: | none → victoria-1 |
tags: | added: train-backport-potential ussuri-backport-potential |
Changed in tripleo: | |
assignee: | James Slagle (james-slagle) → Emilien Macchi (emilienm) |
Fix proposed to branch: master /review. opendev. org/739594
Review: https:/