multinode-ipa tests are failing standalone deployment - 'regsubst' parameter 'target' expects a value of type Array or String, got Undef-

[Ronelle Landy]

periodic-tripleo-ci-rhel-8-standalone-on-multinode-ipa-rhos-17 and periodic-tripleo-ci-centos-8-standalone-on-multinode-ipa-master are failing on the standalone deployment step.

logs/undercloud/var/log/containers/stdouts/container-puppet-rabbitmq.log shows:

2020-07-02T01:43:57.689385982+00:00 stderr F <13>Jul 2 01:43:50 puppet-user: Error: Facter: error while resolving custom fact "rabbitmq_nodename": undefined method `[]' for nil:NilClass
2020-07-02T01:43:59.829015767+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
2020-07-02T01:43:59.829015767+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: (file: /etc/puppet/hiera.yaml)
2020-07-02T01:43:59.829460000+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: Warning: Undefined variable '::deploy_config_name';
2020-07-02T01:43:59.829460000+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: (file & line not available)
2020-07-02T01:43:59.959127572+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/6.14/deprecated_language.html
2020-07-02T01:43:59.959127572+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: (file & line not available)
2020-07-02T01:43:59.993745022+00:00 stderr F <13>Jul 2 01:43:59 puppet-user: Error: Evaluation Error: Error while evaluating a Function Call, 'regsubst' parameter 'target' expects a value of type Array or String, got Undef (file: /etc/puppet/modules/tripleo/manifests/profile/base/rabbitmq.pp, line: 161, column: 33) on node standalone-0.ooo.test

Example logs are below:

https://logserver.rdoproject.org/openstack-periodic-master/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-centos-8-standalone-on-multinode-ipa-master/cd9fee6/logs/undercloud/var/log/containers/stdouts/container-puppet-rabbitmq.log.txt.gz

https://sf.hosted.upshift.rdu2.redhat.com/logs/openstack-periodic-rhos-17/opendev.org/openstack/tripleo-ci/master/periodic-tripleo-ci-rhel-8-standalone-on-multinode-ipa-rhos-17/5166876/logs/undercloud/var/log/containers/stdouts/container-puppet-rabbitmq.log

This error does not show up in ussuri.

[Ronelle Landy (rlandy)]

In master, we see this error from 06/27:

https://review.rdoproject.org/zuul/builds?pipeline=openstack-periodic-master&job_name=periodic-tripleo-ci-centos-8-standalone-on-multinode-ipa-master

[Ronelle Landy (rlandy)]

This is a promotion blocker downstream but not upstream

[Alex Schultz (alex-schultz)]

https://review.opendev.org/#/c/737733/ caused it, needs a check to make sure erl args are defined before repalcing

[Ronelle Landy (rlandy)]

Testing fix: https://review.opendev.org/739134

[Alex Schultz (alex-schultz)]

https://review.opendev.org/#/c/738650/ should fix this