tripleo

Ansible shell module should detect return code on multiline

Bug #1885924 reported by Sergii Golovatiuk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Sergii Golovatiuk
tripleo victoria-1 "tripleo victoria"

Bug Description

This bug is follow up of https://review.opendev.org/#/c/737249/2/deployment/haproxy/haproxy-public-tls-inject.yaml

shell: | needs to have set -e as first command in several places. Otherwise, we won't be able to detect/catch the actual failure.

Sergii Golovatiuk (sgolovatiuk)
Changed in tripleo:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Grzegorz Grasza (xek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/739470

Changed in tripleo:
assignee: Grzegorz Grasza (xek) → Sergii Golovatiuk (sgolovatiuk)
status: Confirmed → In Progress
Bogdan Dobrelya (bogdando)
Changed in tripleo:
importance: Medium → High
milestone: none → victoria-1
tags: added: train-backport-potential ussuri-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/739470
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1192ea1684f607d647e46b96471d921e0d05342b
Submitter: Zuul
Branch: master

commit 1192ea1684f607d647e46b96471d921e0d05342b
Author: Sergii Golovatiuk <email address hidden>
Date: Mon Jul 6 13:53:29 2020 +0200

    Task should fail on any failure

    Ansible should fail on any command in this task not only on last one.

    Change-Id: I257c0f4f73e616f159860916ec1db704bd195b86
    Closes-Bug: #1885924

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/740111

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/740112

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/ussuri)

Reviewed: https://review.opendev.org/740111
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3c48469a74c732fa0426f87696687966bf32a626
Submitter: Zuul
Branch: stable/ussuri

commit 3c48469a74c732fa0426f87696687966bf32a626
Author: Sergii Golovatiuk <email address hidden>
Date: Mon Jul 6 13:53:29 2020 +0200

    Task should fail on any failure

    Ansible should fail on any command in this task not only on last one.

    Change-Id: I257c0f4f73e616f159860916ec1db704bd195b86
    Closes-Bug: #1885924
    (cherry picked from commit 1192ea1684f607d647e46b96471d921e0d05342b)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/740112
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=4e0604603140d4838048dc2414e8916257bf59b3
Submitter: Zuul
Branch: stable/train

commit 4e0604603140d4838048dc2414e8916257bf59b3
Author: Sergii Golovatiuk <email address hidden>
Date: Mon Jul 6 13:53:29 2020 +0200

    Task should fail on any failure

    Ansible should fail on any command in this task not only on last one.

    Change-Id: I257c0f4f73e616f159860916ec1db704bd195b86
    Closes-Bug: #1885924
    (cherry picked from commit 1192ea1684f607d647e46b96471d921e0d05342b)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.