Excessive use of set_fact increases overall number of tasks

[Emilien Macchi]

There are way too many set_fact tasks in our roles and some of them could just be replaced by setting vars into the tasks directly.

set_fact task is time and memory consuming, in the long term goal of making deployment and operations more scalable and faster we want to replace these tasks when possible.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/737337

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/737340

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/737423

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/737340
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=1fd3a3654df8d0ca09434a5dfd03a6da38fbc660
Submitter: Zuul
Branch: stable/train

commit 1fd3a3654df8d0ca09434a5dfd03a6da38fbc660
Author: Emilien Macchi <email address hidden>
Date: Mon Jun 22 13:38:40 2020 -0400

    Cleanup all container startup configs before generating the new ones

    Unlike the container puppet configs [1], we didn't have a mechanism that
    was purging the old configs previously generated by the container
    startup config tasks. It's problematic when some leftover configs are
    still on the host and not needed anymore.

    [1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py#L157-L159

    Change-Id: I24dac79f2351a1ffd4e956584a80f623706cbd00
    Closes-Bug: #1884537
    (cherry picked from commit b1d3da8666880d70db9b588ed4b743b2aaaab914)

[Emilien Macchi (emilienm)]

Will be addressed by https://review.opendev.org/#/c/737438/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/737337
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=88446a6d890a941fc8e52d8bf1db87397a11ce61
Submitter: Zuul
Branch: master

commit 88446a6d890a941fc8e52d8bf1db87397a11ce61
Author: Emilien Macchi <email address hidden>
Date: Mon Jun 22 13:38:40 2020 -0400

    Cleanup all container startup configs before generating the new ones

    Unlike the container puppet configs [1], we didn't have a mechanism that
    was purging the old configs previously generated by the container
    startup config tasks. It's problematic when some leftover configs are
    still on the host and not needed anymore.

    [1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py#L157-L159

    Change-Id: I24dac79f2351a1ffd4e956584a80f623706cbd00
    Closes-Bug: #1884537

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/737423
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=de45a1fc61ea89c93a2e1a8d3d2e729c75017362
Submitter: Zuul
Branch: stable/ussuri

commit de45a1fc61ea89c93a2e1a8d3d2e729c75017362
Author: Emilien Macchi <email address hidden>
Date: Mon Jun 22 13:38:40 2020 -0400

    Cleanup all container startup configs before generating the new ones

    Unlike the container puppet configs [1], we didn't have a mechanism that
    was purging the old configs previously generated by the container
    startup config tasks. It's problematic when some leftover configs are
    still on the host and not needed anymore.

    [1] https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/ansible_plugins/modules/container_puppet_config.py#L157-L159

    Change-Id: I24dac79f2351a1ffd4e956584a80f623706cbd00
    Closes-Bug: #1884537
    (cherry picked from commit b1d3da8666880d70db9b588ed4b743b2aaaab914)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.