tripleo-repos doesn't handle component repos correctly for includepkgs

Bug #1884129 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Alex Schultz

Bug Description

When the repos used to be a single repo, we would just append includepkgs to the file when using current-tripleo-dev. Now because it has multiple repos in a single file, the last repo gets the includepkgs. We need to add it to all the repos within a file if more than one repo is in a file.

We get:

[delorean-component-swift]
name=delorean-openstack-swift-51a587ed8dd5700b558ad26d70dcb7facc0f91e4
baseurl=http://host/centos8/component/swift/51/a5/51a587ed8dd5700b558ad26d70dcb7facc0f91e4_94f16497
enabled=1
gpgcheck=0
priority=10

[delorean-component-tempest]
name=delorean-python-trove-tests-tempest-2970fb81dcdb8ade69807119e104abf2a86811f9
baseurl=http://host/centos8/component/tempest/29/70/2970fb81dcdb8ade69807119e104abf2a86811f9_181d0225
enabled=1
gpgcheck=0
priority=10

[delorean-component-tripleo]
name=delorean-puppet-cinder-a70f39488f1ff21ab16fb4b323ac5061490d85e1
baseurl=http://host/centos8/component/tripleo/a7/0f/a70f39488f1ff21ab16fb4b323ac5061490d85e1_9b289e98
enabled=1
gpgcheck=0
priority=10

[delorean-component-ui]
name=delorean-openstack-sahara-ui-0a891cf2328c014af8c6f2773af7cb0b7a167385
baseurl=http://host/centos8/component/ui/0a/89/0a891cf2328c014af8c6f2773af7cb0b7a167385_ab580f7c
enabled=1
gpgcheck=0
priority=10

includepkgs=instack,instack-undercloud,os-apply-config,os-collect-config,os-net-config,os-refresh-config,python*-tripleoclient,openstack-tripleo-*,openstack-puppet-modules,ansible-role-tripleo*,puppet-*,python*-tripleo-common,python*-paunch*,tripleo-ansible,ansible-config_template

Instead of just:

[delorean-current]
name=delorean-openstack-sahara-ui-0a891cf2328c014af8c6f2773af7cb0b7a167385
baseurl=http://host/centos8/component/ui/0a/89/0a891cf2328c014af8c6f2773af7cb0b7a167385_ab580f7c
enabled=1
gpgcheck=0
priority=10

includepkgs=instack,instack-undercloud,os-apply-config,os-collect-config,os-net-config,os-refresh-config,python*-tripleoclient,openstack-tripleo-*,openstack-puppet-modules,ansible-role-tripleo*,puppet-*,python*-tripleo-common,python*-paunch*,tripleo-ansible,ansible-config_template

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-repos (master)

Fix proposed to branch: master
Review: https://review.opendev.org/736811

Changed in tripleo:
assignee: nobody → Alex Schultz (alex-schultz)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-repos (master)

Reviewed: https://review.opendev.org/736811
Committed: https://git.openstack.org/cgit/openstack/tripleo-repos/commit/?id=f18928aa862d97814b6cd49bbcea955e45c5f3fb
Submitter: Zuul
Branch: master

commit f18928aa862d97814b6cd49bbcea955e45c5f3fb
Author: Alex Schultz <email address hidden>
Date: Thu Jun 18 13:26:17 2020 -0600

    Fix component handling

    Since the we split the repos into components, a single delorean repo
    file can contain many repos. For current-tripleo-dev we only want to
    include certain packages from all the current repos. This change
    processes the repo file to append includepkgs to all repos defined in a
    single file. Additionally it adjusts the repo names to prevent conflicts
    and addresses priority is missing from a file with multiple repos.

    Change-Id: Ifb301609bf29a6a171c284647baea233a7dd07cc
    Closes-Bug: #1884129

Changed in tripleo:
status: In Progress → Fix Released
Changed in tripleo:
milestone: none → victoria-3
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.