network default gateway can't be updated by t-h-t paramter

[Takashi Kajinami]

Since the following patch was introduced, we can't override default route
by t-h-t parameter, {{network.name}}InterfaceDefaultRoute .
 https://github.com/openstack/tripleo-heat-templates/commit/ce9a83c8cd95cdc8cebce46eb69f37ba1235d14d

This isn't consistent with the other network parameters like SubnetCidr,
which allows override by t-h-t parameters as well as customized network data

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/732692

[OpenStack Infra (hudson-openstack)]

Change abandoned by Takashi Kajinami (<email address hidden>) on branch: stable/train
Review: https://review.opendev.org/732692
Reason: ahh sorry. I accidentally created this patch against train. will fix master first.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/732698

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/732698
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=396b26fe9b67aebf9b3a7badc9b82be5380ce237
Submitter: Zuul
Branch: master

commit 396b26fe9b67aebf9b3a7badc9b82be5380ce237
Author: Takashi Kajinami <email address hidden>
Date: Wed Jun 3 01:09:32 2020 +0900

    Allow overriding InterfaceDefaultRoute with ips_from_pool template

    Currently InterfaceDefaultRoute doesn't affect when ips_from_pool
    template is used, and gateway_ip in network_data is always picked up.
    This patch allows operators to override default route by the parameter
    even when ips_from_pool template is used.

    Note that this patch also fixes incorrect handling about subnet in
    ips_from_pool template when ipv6 is enabled.

    Closes-Bug: #1881768
    Change-Id: I2f0f60052c1acfc971fe3d5195f9499e45068396

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/736093

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/736093
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=454a0e6520b8ff324b7b4b649837c6c76628a260
Submitter: Zuul
Branch: stable/ussuri

commit 454a0e6520b8ff324b7b4b649837c6c76628a260
Author: Takashi Kajinami <email address hidden>
Date: Wed Jun 3 01:09:32 2020 +0900

    Allow overriding InterfaceDefaultRoute with ips_from_pool template

    Currently InterfaceDefaultRoute doesn't affect when ips_from_pool
    template is used, and gateway_ip in network_data is always picked up.
    This patch allows operators to override default route by the parameter
    even when ips_from_pool template is used.

    Note that this patch also fixes incorrect handling about subnet in
    ips_from_pool template when ipv6 is enabled.

    Closes-Bug: #1881768
    Change-Id: I2f0f60052c1acfc971fe3d5195f9499e45068396
    (cherry picked from commit 396b26fe9b67aebf9b3a7badc9b82be5380ce237)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/732692
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=247105809b02d65d828b1f2f009c40972c04146c
Submitter: Zuul
Branch: stable/train

commit 247105809b02d65d828b1f2f009c40972c04146c
Author: Takashi Kajinami <email address hidden>
Date: Wed Jun 3 01:09:32 2020 +0900

    Allow overriding InterfaceDefaultRoute with ips_from_pool template

    Currently InterfaceDefaultRoute doesn't affect when ips_from_pool
    template is used, and gateway_ip in network_data is always picked up.
    This patch allows operators to override default route by the parameter
    even when ips_from_pool template is used.

    Note that this patch also fixes incorrect handling about subnet in
    ips_from_pool template when ipv6 is enabled.

    Closes-Bug: #1881768
    Change-Id: I2f0f60052c1acfc971fe3d5195f9499e45068396
    (cherry picked from commit 396b26fe9b67aebf9b3a7badc9b82be5380ce237)
    (cherry picked from commit 454a0e6520b8ff324b7b4b649837c6c76628a260)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.