octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servername in octavia api template

[Brent Eagles]

original bug https://bugzilla.redhat.com/show_bug.cgi?id=1829479

Apparently during an investigation of why health check was failing, an inconsistency with the server name hiera/octavia puppet was found.

"hiera parameter octavia::wsgi::apache::server_name should be octavia::wsgi::apache::servername in puppet/services/octavia-api.yaml to match the parameter in the puppet module. Currently, always set to $::fqdn."

This should be getting the hostname on the octavia api network, not whatever fqdn resolves to.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/725877

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725877
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=dac08c4f0ebc79d0003a6a4610bbc240a808da22
Submitter: Zuul
Branch: master

commit dac08c4f0ebc79d0003a6a4610bbc240a808da22
Author: Brent Eagles <email address hidden>
Date: Wed May 6 12:07:26 2020 -0230

    Fix typo in setting octavia wsgi server name

    hiera was being set as server_name when it should've been servername.

    Change-Id: I08c4562308a5a5ce93e64a7485ab207af2241565
    Closes-Bug: #1877130

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/726375

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/726375
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=51565c0c3d2340c18b8e81cc540720fb711c6dad
Submitter: Zuul
Branch: stable/train

commit 51565c0c3d2340c18b8e81cc540720fb711c6dad
Author: Brent Eagles <email address hidden>
Date: Wed May 6 12:07:26 2020 -0230

    Fix typo in setting octavia wsgi server name

    hiera was being set as server_name when it should've been servername.

    Change-Id: I08c4562308a5a5ce93e64a7485ab207af2241565
    Closes-Bug: #1877130
    (cherry picked from commit dac08c4f0ebc79d0003a6a4610bbc240a808da22)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/739233

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739233
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ec1bcec1eaa184ef3b935f082cc465227e72d2ca
Submitter: Zuul
Branch: stable/stein

commit ec1bcec1eaa184ef3b935f082cc465227e72d2ca
Author: Brent Eagles <email address hidden>
Date: Wed May 6 12:07:26 2020 -0230

    Fix typo in setting octavia wsgi server name

    hiera was being set as server_name when it should've been servername.

    Change-Id: I08c4562308a5a5ce93e64a7485ab207af2241565
    Closes-Bug: #1877130
    (cherry picked from commit dac08c4f0ebc79d0003a6a4610bbc240a808da22)
    (cherry picked from commit 51565c0c3d2340c18b8e81cc540720fb711c6dad)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/739234
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=bc6d55acef48b4a717c2f9966760b6560566858a
Submitter: Zuul
Branch: stable/rocky

commit bc6d55acef48b4a717c2f9966760b6560566858a
Author: Brent Eagles <email address hidden>
Date: Fri Jul 3 11:24:01 2020 -0230

    Fix typo in setting octavia wsgi server name

    hiera was being set as server_name when it should've been servername.

    Note: this is semantic backport of https://review.opendev.org/#/c/725877/
    which could not be cherry picked because of file reorganization.

    Closes-Bug: #1877130
    Change-Id: Ic8a938235de59f4d3547f7e632233f9fe16220aa

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/741223

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/741223
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a8686b41d266bfc03ea321c609a962a4ee2941c1
Submitter: Zuul
Branch: stable/queens

commit a8686b41d266bfc03ea321c609a962a4ee2941c1
Author: Brent Eagles <email address hidden>
Date: Fri Jul 3 11:24:01 2020 -0230

    Fix typo in setting octavia wsgi server name

    hiera was being set as server_name when it should've been servername.

    Note: this is semantic backport of https://review.opendev.org/#/c/725877/
    which could not be cherry picked because of file reorganization.

    Closes-Bug: #1877130
    Change-Id: Ic8a938235de59f4d3547f7e632233f9fe16220aa
    (cherry picked from commit bc6d55acef48b4a717c2f9966760b6560566858a)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates rocky-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates stein-eol release.