[S->T] 'ovn_dbs_short_bootstrap_node_name' is undefined

Bug #1875579 reported by Jose Luis Franco
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Jesse Pretorius

Bug Description

hen performing an upgrade from Stein to Train, the Controllers upgrade step fails with:

TASK [Restart ovn-dbs service (pacemaker)] *************************************
Tuesday 28 April 2020 05:46:19 +0000 (0:00:02.384) 0:00:11.318 *********
fatal: [controller-0]: FAILED! => {"msg": "The conditional check 'ovn_dbs_short_bootstrap_node_name|lower == ansible_hostname|lower' failed. The error was: error while evaluating conditional (ovn_dbs_short_bootstrap_node_name|lower == ansible_hostname|lower): 'ovn_dbs_short_bootstrap_node_name' is undefined\n\nThe error appears to be in '/var/lib/mistral/1724455b-7bfb-47ad-98d5-37762b2f0750/Controller/post_upgrade_tasks.yaml': line 6, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 1\n- name: Restart ovn-dbs service (pacemaker)\n ^ here\n"}
fatal: [controller-1]: FAILED! => {"msg": "The conditional check 'ovn_dbs_short_bootstrap_node_name|lower == ansible_hostname|lower' failed. The error was: error while evaluating conditional (ovn_dbs_short_bootstrap_node_name|lower == ansible_hostname|lower): 'ovn_dbs_short_bootstrap_node_name' is undefined\n\nThe error appears to be in '/var/lib/mistral/1724455b-7bfb-47ad-98d5-37762b2f0750/Controller/post_upgrade_tasks.yaml': line 6, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 1\n- name: Restart ovn-dbs service (pacemaker)\n ^ here\n"}
fatal: [controller-2]: FAILED! => {"msg": "The conditional check 'ovn_dbs_short_bootstrap_node_name|lower == ansible_hostname|lower' failed. The error was: error while evaluating conditional (ovn_dbs_short_bootstrap_node_name|lower == ansible_hostname|lower): 'ovn_dbs_short_bootstrap_node_name' is undefined\n\nThe error appears to be in '/var/lib/mistral/1724455b-7bfb-47ad-98d5-37762b2f0750/Controller/post_upgrade_tasks.yaml': line 6, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n when: step|int == 1\n- name: Restart ovn-dbs service (pacemaker)\n ^ here\n"}

It looks like the common_deploy_steps_playbooks.yaml isn't been imported for the post_upgrade_tasks as it is being done before running upgrade_tasks:
- import_playbook: common_deploy_steps_playbooks.yaml
  vars:
    deploy_source_host: "Undercloud"
    deploy_target_host: "qe-Cloud-0"

cat post_upgrade_steps_playbook.yaml

- hosts: qe-Cloud-0
  any_errors_fatal: yes
  tasks:
    - include_tasks: post_upgrade_steps_tasks.yaml
      with_sequence: start=0 end=3
      vars:
        bootstrap_server_id: cdb5191f-7598-4345-8a6f-61192da89175
        deploy_identifier: 1588020793
        enable_debug: True
        enable_puppet: True
        container_cli: podman
        container_log_stdout_path: /var/log/containers/stdouts
        container_healthcheck_disabled: False
        docker_puppet_debug: False
        docker_puppet_process_count: 8
        docker_puppet_mount_host_puppet: True
      loop_control:
        loop_var: step

Changed in tripleo:
assignee: nobody → Jose Luis Franco (jfrancoa)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/723833

Changed in tripleo:
status: Triaged → In Progress
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc1 → ussuri-rc3
Changed in tripleo:
assignee: Jose Luis Franco (jfrancoa) → Jesse Pretorius (jesse-pretorius)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/728956

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/723833
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=2c85bde0005d82ee08da7f42011b3a90be0263c8
Submitter: Zuul
Branch: master

commit 2c85bde0005d82ee08da7f42011b3a90be0263c8
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Apr 28 10:09:52 2020 +0200

    Add common_deploy_steps to post_upgrade_steps.

    When refactoring deploy-steps to add a common playbook [0] it seems that
    the post_upgrade_steps_playbook block was missed. As a consequence, when
    executing the post_upgrade_tasks some of the common Ansible variables
    are not available.

    [0] - Ib00e8aa9f7d06517290543a8aaf8a2527969bd3c

    Change-Id: I04704a14a8b932e21d21348e10014c707a87eeeb
    Closes-Bug: #1875579

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/728956
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6e3c933ffe56c362304337286f4992dca13ec10a
Submitter: Zuul
Branch: stable/train

commit 6e3c933ffe56c362304337286f4992dca13ec10a
Author: Jose Luis Franco Arza <email address hidden>
Date: Tue Apr 28 10:09:52 2020 +0200

    Add common_deploy_steps to post_upgrade_steps.

    When refactoring deploy-steps to add a common playbook [0] it seems that
    the post_upgrade_steps_playbook block was missed. As a consequence, when
    executing the post_upgrade_tasks some of the common Ansible variables
    are not available.

    [0] - Ib00e8aa9f7d06517290543a8aaf8a2527969bd3c

    Change-Id: I04704a14a8b932e21d21348e10014c707a87eeeb
    Closes-Bug: #1875579
    (cherry picked from commit 2c85bde0005d82ee08da7f42011b3a90be0263c8)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.