tripleo

undercloud install errors out on duplicate entries in undercloud.conf

Bug #1874410 reported by Michele Baldessari on 2020-04-23

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Kevin Carter	tripleo ussuri-rc1 "tripleo ussuri-rc1"

Bug Description

Via I94257d1d5ceb2795f5d9596a6a1d5066d881c3b7 we added the following code:
try:
    if os.path.exists(UNDERCLOUD_CONF_PATH):
        config = cfgp.ConfigParser()
        config.read(UNDERCLOUD_CONF_PATH)
        UNDERCLOUD_OUTPUT_DIR = config.get('DEFAULT', 'output_dir')
    else:
        raise FileNotFoundError

Since python3.2 config parser will error out on duplicate entries https://docs.python.org/3/library/configparser.html, so previously working files with duplicate entries now suddenly stop working.

Tags:

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-04-23: Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/722239

Changed in tripleo:
assignee:	nobody → Michele Baldessari (michele)
status:	Triaged → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-04-23: Change abandoned on python-tripleoclient (master)

Change abandoned by Michele Baldessari (<email address hidden>) on branch: master
Review: https://review.opendev.org/722239

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-04-23: Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/722342

Changed in tripleo:
assignee:	Michele Baldessari (michele) → Kevin Carter (kevin-carter)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-04-23: Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/722385

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-04-23: Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/722342
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=93952566d6615deb2c81467df7743d872ff77e8d
Submitter: Zuul
Branch: master

commit 93952566d6615deb2c81467df7743d872ff77e8d
Author: Kevin Carter <email address hidden>
Date: Thu Apr 23 09:49:45 2020 -0500

Add release note for undercloud.conf parsing

This change adds a release note to cover the strict parsing of the `undercloud.conf`.

    Closes-Bug: #1874410
    Change-Id: Ic3aa73b28f46694a5ce43f8435a64e195df1328f
    Signed-off-by: Kevin Carter <email address hidden>

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2020-04-24: Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/722385
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=b95119250c11ab28c6777ec8dcbac96750b0f859
Submitter: Zuul
Branch: stable/train

commit b95119250c11ab28c6777ec8dcbac96750b0f859
Author: Kevin Carter <email address hidden>
Date: Thu Apr 23 09:49:45 2020 -0500

Add release note for undercloud.conf parsing

This change adds a release note to cover the strict parsing of the `undercloud.conf`.

    Closes-Bug: #1874410
    Change-Id: Ic3aa73b28f46694a5ce43f8435a64e195df1328f
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 93952566d6615deb2c81467df7743d872ff77e8d)