puppet-openstack-unit-5.5-centos-8 is broken because of puppet modules incompatible with CentOS8

[Takashi Kajinami]

Currently puppet-openstack-unit-5.5-centos-8 is failing because we still use old version of puppet modules, which are incompatible with CentOS8

https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d29/718106/2/check/puppet-openstack-unit-5.5-centos-8/d291685/job-output.txt

~~~
2020-04-13 23:42:50.334559 | centos-8 | 1) tripleo::profile::base::database::redis on centos-8-x86_64 behaves like tripleo::profile::base::database::redis with step 2 on bootstrap node should configure redis
2020-04-13 23:42:50.334576 | centos-8 | Failure/Error: is_expected.to contain_class('tripleo::profile::base::database::redis')
2020-04-13 23:42:50.334591 | centos-8 |
2020-04-13 23:42:50.334607 | centos-8 | Puppet::PreformattedError:
2020-04-13 23:42:50.334632 | centos-8 | Evaluation Error: Error while evaluating a Function Call, Not sure what Redis version is avaliable upstream on your release: 8 (file: /home/zuul/workspace/spec/fixtures/modules/redis/manifests/params.pp, line: 211, column: 11) on node centos-8-inap-mtl01-0015902273
~~~

~~~
2020-04-13 23:42:50.368725 | centos-8 | 9) tripleo::profile::base::etcd on centos-8-x86_64 behaves like tripleo::profile::base::etcd with step 2 with defaults should configure etcd with defaults
2020-04-13 23:42:50.368742 | centos-8 | Failure/Error:
2020-04-13 23:42:50.368758 | centos-8 | is_expected.to contain_class('etcd').with(
2020-04-13 23:42:50.368775 | centos-8 | :listen_client_urls => 'http://127.0.0.1:2379',
2020-04-13 23:42:50.368808 | centos-8 | :advertise_client_urls => 'http://127.0.0.1:2379',
2020-04-13 23:42:50.368827 | centos-8 | :listen_peer_urls => 'http://127.0.0.1:2380',
2020-04-13 23:42:50.368847 | centos-8 | :initial_advertise_peer_urls => 'http://127.0.0.1:2380',
2020-04-13 23:42:50.368866 | centos-8 | :initial_cluster => [],
2020-04-13 23:42:50.368886 | centos-8 | :proxy => 'off',
2020-04-13 23:42:50.368905 | centos-8 | :cert_file => nil,
2020-04-13 23:42:50.368925 | centos-8 | :key_file => nil,
2020-04-13 23:42:50.368944 | centos-8 | :client_cert_auth => false,
2020-04-13 23:42:50.368963 | centos-8 |
2020-04-13 23:42:50.368983 | centos-8 | Puppet::PreformattedError:
2020-04-13 23:42:50.369003 | centos-8 | Evaluation Error: Error while evaluating a Function Call, Unsupported RedHat release. (file: /home/zuul/workspace/spec/fixtures/modules/etcd/manifests/params.pp, line: 16, column: 21) on node centos-8-inap-mtl01-0015902273
~~~

~~~
2020-04-13 23:42:50.397004 | centos-8 | 17) tripleo::profile::base::neutron::opendaylight on centos-8-x86_64 behaves like tripleo::profile::base::neutron::opendaylight with noha should install and configure opendaylight
2020-04-13 23:42:50.397021 | centos-8 | Failure/Error: is_expected.to contain_class('opendaylight')
2020-04-13 23:42:50.397038 | centos-8 |
2020-04-13 23:42:50.397055 | centos-8 | Puppet::PreformattedError:
2020-04-13 23:42:50.397079 | centos-8 | Evaluation Error: Error while evaluating a Function Call, Unsupported OS: CentOS 8 (file: /home/zuul/workspace/spec/fixtures/modules/opendaylight/manifests/init.pp, line: 142, column: 9) on node centos-8-inap-mtl01-0015902273
~~~

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/719699

[Takashi Kajinami (kajinamit)]

About puppet-redis, we need >= 4.0.0
 https://github.com/voxpupuli/puppet-redis/commit/f2a30d6c5a9c830e0552486e4d1cb4590ed445fe

About puppet-etcd, we should switch to puppet-etcd and need >= 1.12.3
 https://github.com/puppet-etcd/puppet-etcd/commit/39faa948f68c8e8ac0337ea74c1406da776cd71b

OpenDaylight support is currently under removal, so we don't need to care about it now.
 https://review.opendev.org/#/c/719440/

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/719699
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=4072d4033d4003be2aa8d1a2308587642d642cf1
Submitter: Zuul
Branch: master

commit 4072d4033d4003be2aa8d1a2308587642d642cf1
Author: Takashi Kajinami <email address hidden>
Date: Tue Apr 14 09:06:07 2020 +0900

    Revert "Update metadata to support el8 instead of el7"

    This reverts commit ff22e7c2687bc8f67d6769c32b235257ac0f8e5f.

    Change-Id: Idc654bd3fc42b4005527cdf833ed24e9e2bf2963
    Closes-Bug: #1872562

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/719987
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=1ca336329b2b604fb811e8e909ceac7d96894460
Submitter: Zuul
Branch: master

commit 1ca336329b2b604fb811e8e909ceac7d96894460
Author: Takashi Kajinami <email address hidden>
Date: Tue Apr 14 23:23:55 2020 +0900

    Update metadata to support el8 instead of el7 again

    This patch again updates metadata to support el8 instead of el7, which
    was initially merged[1] but reverted because of failures in unit tests
    caused by old puppet modules installed as dependencies.

    This patch removes version cap for puppet-etcd and puppet-redis, so
    that we can use their lastet verions compatible with el8.

    [1] ff22e7c2687bc8f67d6769c32b235257ac0f8e5f

    Related-Bug: #1872562
    Change-Id: I3924d35fae48accb57186c1c5c0a3192bacccda6