ceph health validation not working properly during upgrades

[Francesco Pantano]

The upgrade from queens path is broken due to the a wrong container_cli fact.
After the undercloud is updated, the default 'container_cli' is podman in the undercloud, but it's still docker in the overcloud and this let the validation playbook to fail because this fact is derived from inventory_hostname that still points to the undercloud.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/718011
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=3baced6e89d4d3af7d2190f4c587a4ee05f5977a
Submitter: Zuul
Branch: master

commit 3baced6e89d4d3af7d2190f4c587a4ee05f5977a
Author: Francesco Pantano <email address hidden>
Date: Tue Apr 7 11:07:06 2020 +0200

    Introducing tripleo_delegate_to on ceph health validation

    The purpose of this change is to fix the upgrade scenario
    without breaking the existing validation for the
    deployment phase. During the upgrade from queens, the
    default 'container_cli' is podman in the undercloud (which
    is updated), but it's still docker in the overcloud and this
    let the validation playbook to fail because we're computing
    this fact starting from inventory_hostname that still points
    to the undercloud. This issue can be solved by removing the
    delegation directive from tht and rely on tripleo delegate
    wrapper.
    This should be enough to access the overcloud (ceph_mon)
    variables, setting the right fact.

    Closes-Bug: #1871380
    Change-Id: I46c4fbe0ef7b281d77bff82483eb0b48b4570bb3

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/718012
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e806c02852a50aa7890c7b0527a2e6968592079b
Submitter: Zuul
Branch: master

commit e806c02852a50aa7890c7b0527a2e6968592079b
Author: Francesco Pantano <email address hidden>
Date: Tue Apr 7 11:27:03 2020 +0200

    Add tripleo_delegate_to var for ceph health validation

    According to the tripleo-validation change, we're just
    moving from the default ansible delegate_to to the
    tripleo_delegate_to directive provided by TripleO.
    This ensure the task is executed using the overcloud
    facts, fixing the upgrade (from queens) scenario.

    Depends-On: https://review.opendev.org/718011
    Closes-Bug: #1871380
    Change-Id: I08e44544e1069c5fd1b2d9832c6778ff32427369

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/725303

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/725304

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725303
Committed: https://git.openstack.org/cgit/openstack/tripleo-validations/commit/?id=4b27bcd01b6dc506c7b63c51846b6d17b7b42ed7
Submitter: Zuul
Branch: stable/train

commit 4b27bcd01b6dc506c7b63c51846b6d17b7b42ed7
Author: Francesco Pantano <email address hidden>
Date: Tue Apr 7 11:07:06 2020 +0200

    Introducing tripleo_delegate_to on ceph health validation

    The purpose of this change is to fix the upgrade scenario
    without breaking the existing validation for the
    deployment phase. During the upgrade from queens, the
    default 'container_cli' is podman in the undercloud (which
    is updated), but it's still docker in the overcloud and this
    let the validation playbook to fail because we're computing
    this fact starting from inventory_hostname that still points
    to the undercloud. This issue can be solved by removing the
    delegation directive from tht and rely on tripleo delegate
    wrapper.
    This should be enough to access the overcloud (ceph_mon)
    variables, setting the right fact.

    Closes-Bug: #1871380
    Change-Id: I46c4fbe0ef7b281d77bff82483eb0b48b4570bb3
    (cherry picked from commit 3baced6e89d4d3af7d2190f4c587a4ee05f5977a)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725304
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=fd775e50a1ae84df50cb33f8af0ccb727f482a15
Submitter: Zuul
Branch: stable/train

commit fd775e50a1ae84df50cb33f8af0ccb727f482a15
Author: Francesco Pantano <email address hidden>
Date: Tue Apr 7 11:27:03 2020 +0200

    Add tripleo_delegate_to var for ceph health validation

    According to the tripleo-validation change, we're just
    moving from the default ansible delegate_to to the
    tripleo_delegate_to directive provided by TripleO.
    This ensure the task is executed using the overcloud
    facts, fixing the upgrade (from queens) scenario.

    Depends-On: https://review.opendev.org/#/c/725303/
    Closes-Bug: #1871380
    Change-Id: I08e44544e1069c5fd1b2d9832c6778ff32427369
    (cherry picked from commit e806c02852a50aa7890c7b0527a2e6968592079b)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-validations 11.4.0 release.