When scaling out a new node, incorrect number sequence in server-name

[James Bagwell]

Description
===========
After a successful deployment, and successful scale-in (remove node) , and after a successful scale-out (add node) , baremetal list returns a strange server name. 10 servers were installed, 1 was removed, 1 was scaled out, so the next incremental name should be "server-11" . Instead, we see "server-19" . Server naming in baremetal node list does not appear to be incrementing properly for elasticity operations.

Steps to reproduce
==================
After a successful stack deployment, I have the following output using openstack baremetal node list:

 +--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
| 5e39457a-8135-4fe8-975d-47814f718f34 | server-1 | 40e7a069-3d3a-408e-bc03-b0b669d2b996 | power on | active | False |
| 38e76b57-fd29-4afc-9b13-1fc99893e523 | server-2 | 6a226e47-ea04-41c8-8d0c-6a3449043a44 | power on | active | False |
| 01920f2d-fe78-4098-b386-00d7c6726eda | server-3 | f90d146e-d987-4029-9fbb-865ac7b73572 | power on | active | False |
| 08efc766-079b-4c4d-9f9c-465681b975f8 | server-4 | 1face550-2af3-4cb1-82e6-8e3d2e5635c6 | power on | active | False |
| ee56ec56-ac12-45b1-bcf8-b586662008ff | server-5 | ffe054c8-d3b6-42ad-af71-2adb4bf22608 | power on | active | False |
| c6f51176-566b-471a-9c91-49585453146b | server-6 | 23d74f2e-d926-4758-969d-3a4934e8a5ad | power on | active | False |
| b158017b-7e0a-458c-afca-c5d8aedc8045 | server-7 | d749d665-a744-453b-af0a-d5500739e170 | power on | active | False |
| 051f9806-04de-4be4-9474-1c255625e44f | server-8 | 9e4b1224-2798-4088-abfc-9bd0a7547e2d | power on | active | False |
| 4da5913a-fd56-4659-ac23-19c7ac31a2c6 | server-9 | ce2a7098-d26a-4986-bd01-9ceaff7242a4 | power on | active | False |
| bfb97232-8eee-4d2c-8152-2dc81ef52f02 | server-10 | 737697b1-fe89-44d5-8918-e8aa55b70f85 | power on | active | False |
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+

I then removed server-10 via scale-in (remove node)
openstack cbis node remove 737697b1-fe89-44d5-8918-e8aa55b70f85

Now we see the output of the command looks right : ( 1 less server since we removed it )

[stack@undercloud (stackrc) ~]$ openstack baremetal node list
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
| 5e39457a-8135-4fe8-975d-47814f718f34 | server-1 | 40e7a069-3d3a-408e-bc03-b0b669d2b996 | power on | active | False |
| 38e76b57-fd29-4afc-9b13-1fc99893e523 | server-2 | 6a226e47-ea04-41c8-8d0c-6a3449043a44 | power on | active | False |
| 01920f2d-fe78-4098-b386-00d7c6726eda | server-3 | f90d146e-d987-4029-9fbb-865ac7b73572 | power on | active | False |
| 08efc766-079b-4c4d-9f9c-465681b975f8 | server-4 | 1face550-2af3-4cb1-82e6-8e3d2e5635c6 | power on | active | False |
| ee56ec56-ac12-45b1-bcf8-b586662008ff | server-5 | ffe054c8-d3b6-42ad-af71-2adb4bf22608 | power on | active | False |
| c6f51176-566b-471a-9c91-49585453146b | server-6 | 23d74f2e-d926-4758-969d-3a4934e8a5ad | power on | active | False |
| b158017b-7e0a-458c-afca-c5d8aedc8045 | server-7 | d749d665-a744-453b-af0a-d5500739e170 | power on | active | False |
| 051f9806-04de-4be4-9474-1c255625e44f | server-8 | 9e4b1224-2798-4088-abfc-9bd0a7547e2d | power on | active | False |
| 4da5913a-fd56-4659-ac23-19c7ac31a2c6 | server-9 | ce2a7098-d26a-4986-bd01-9ceaff7242a4 | power on
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+

I then scaled-out a node successfully,/usr/bin/python2 /usr/bin/openstack cbis overcloud deploy --scale-out --templates templates/ .. however instead of seeing "server-11" which would be the expected server name increment , we see "server-19".

[stack@undercloud (stackrc) ~]$ openstack baremetal node list
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
| UUID | Name | Instance UUID | Power State | Provisioning State | Maintenance |
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
| 5e39457a-8135-4fe8-975d-47814f718f34 | server-1 | 40e7a069-3d3a-408e-bc03-b0b669d2b996 | power on | active | False |
| 38e76b57-fd29-4afc-9b13-1fc99893e523 | server-2 | 6a226e47-ea04-41c8-8d0c-6a3449043a44 | power on | active | False |
| 01920f2d-fe78-4098-b386-00d7c6726eda | server-3 | f90d146e-d987-4029-9fbb-865ac7b73572 | power on | active | False |
| 08efc766-079b-4c4d-9f9c-465681b975f8 | server-4 | 1face550-2af3-4cb1-82e6-8e3d2e5635c6 | power on | active | False |
| ee56ec56-ac12-45b1-bcf8-b586662008ff | server-5 | ffe054c8-d3b6-42ad-af71-2adb4bf22608 | power on | active | False |
| c6f51176-566b-471a-9c91-49585453146b | server-6 | 23d74f2e-d926-4758-969d-3a4934e8a5ad | power on | active | False |
| b158017b-7e0a-458c-afca-c5d8aedc8045 | server-7 | d749d665-a744-453b-af0a-d5500739e170 | power on | active | False |
| 051f9806-04de-4be4-9474-1c255625e44f | server-8 | 9e4b1224-2798-4088-abfc-9bd0a7547e2d | power on | active | False |
| 4da5913a-fd56-4659-ac23-19c7ac31a2c6 | server-9 | ce2a7098-d26a-4986-bd01-9ceaff7242a4 | power on | active | False |
| 917c0992-07e3-403c-a00b-3c6bc1db0836 | server-19 | ad53ee8c-bd38-4443-a998-69e6527ef706 | power on | active | False |
+--------------------------------------+-----------+--------------------------------------+-------------+--------------------+-------------+
Expected result
===============
After the execution of the steps above, I should see server-11 .

Actual result
=============
Instead, I see "server-19"

Environment
===========
1. Rocky

2. OS CentOS Linux 7.7.1908

kernel 4.18.0
qemu-kvm-ev 2.12.0
libvirt 4.5.0
openvswitch 2.11.0
dpdk 18.11.2

OpenStack Services
aodh 7.0.1
barbican 7.0.1
ceilometer 11.0.2
cinder 13.0.6
glance 17.0.1
gnocchi 4.3.3
heatclient 1.16.2
heat-engine 11.0.3
horizon 14.0.3
keystone 14.1.1
manila 7.3.1
neutron 13.0.4
nova 18.2.1
panko 5.0.1

pacemaker 1.1.20
corosync 2.4.3
haproxy 1.5.18
mariadb 10.1.20
rabbitmq-server 3.6.16

Ceph Storage

ceph-base 12.2.11
ceph-ansible 3.1.6

3.

Logs & Configs
==============

[James Bagwell (jimbagwell)]

Please triage to Heat if you see fit !