container-puppet-keystone_init_tasks seems to be running in multiple steps

[Rabi Mishra]

I think it's expected to run only on step3[1]. But seems to be running for all subsequent steps[2].

[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/keystone/keystone-container-puppet.yaml#L774

[2] https://4d54b9492ec449d86ffb-176806fde7fb6bec4df9cbd788be57b5.ssl.cf1.rackcdn.com/716217/1/check/tripleo-ci-centos-8-containers-multinode/3589cbc/logs/undercloud/var/log/extra/podman/containers/container-puppet-keystone_init_tasks/stdout.log

I think the 'host_container_puppet_tasks' variable does not include step, hence it's host-container-puppet-tasks.yaml is included in all subsequent steps.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/716879

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716879
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6db0ac0856b369ee13dc17db7be7ef8c124a8b4b
Submitter: Zuul
Branch: master

commit 6db0ac0856b369ee13dc17db7be7ef8c124a8b4b
Author: Rabi Mishra <email address hidden>
Date: Thu Apr 2 12:51:21 2020 +0530

    Include {{step}} when setting facts

    We don't set the fact specific to a step and it seems
    to run those puppet tasks for subsequent steps too.

    Change-Id: Ic276ea6f34dd638ad66505aa77bddff0e4071ad4
    Closes-Bug #1870291

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/717526

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/717526
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=86f149ae3059c1a0ab7ec525afe1fc63f29a36a3
Submitter: Zuul
Branch: stable/train

commit 86f149ae3059c1a0ab7ec525afe1fc63f29a36a3
Author: Rabi Mishra <email address hidden>
Date: Thu Apr 2 12:51:21 2020 +0530

    Include {{step}} when setting facts

    We don't set the fact specific to a step and it seems
    to run those puppet tasks for subsequent steps too.

    Change-Id: Ic276ea6f34dd638ad66505aa77bddff0e4071ad4
    Closes-Bug #1870291
    (cherry picked from commit 6db0ac0856b369ee13dc17db7be7ef8c124a8b4b)