'current' repo is being used instead of 'current-tripleo' for non tripleo packages during rpmbuild in tripleo jobs

Bug #1870026 reported by yatin
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
tripleo
Incomplete
High
wes hayutin

Bug Description

rpmbuild should use the same set of repos with mirror config as defined in release files[1]. 'current-tripleo' repo should be used for non tripleo packages and 'current' for tripleo packages.

@ramishra noticed it during one of the CentOS8 job [2], similar usage are there in CentOS7 jobs. repos are configured correctly in build-test-packages role [3], DLRN is pulling additional repos which should be skipped. This is happening as --dev is used during dlrn build[4] and DLRN based on it[5] setups repos. --dev shouldb't be needed in upstream jobs as we are not testing distgit changes, but if it's needed need to have an option in DLRN to skip repo setup.

[1] https://github.com/openstack/tripleo-quickstart/tree/master/config/release/tripleo-ci
[2] https://logserver.rdoproject.org/77/716277/5/openstack-check/tripleo-ci-centos-8-ovb-3ctlr_1comp-featureset001/0f675d5/logs/delorean_logs/component/tripleo/62/c4/62c43e76262a80904a564a71eee256725cca9fc5_dev/rpmbuild.log.txt.gz
[3] https://github.com/openstack/tripleo-quickstart-extras/blob/master/roles/build-test-packages/tasks/main.yml#L154-L169
[4] https://github.com/openstack/tripleo-quickstart-extras/blob/c1086c84da36a680dbc2c94c59bde21d0cbbcf76/roles/build-test-packages/tasks/dlrn-build.yml#L100
[5] https://github.com/softwarefactory-project/DLRN/blob/db90a76a2c4ba744212eec92a605bf131d6d19a9/dlrn/build.py#L215-L233

Tags: alert
yatin (yatinkarel)
Changed in tripleo:
status: New → Triaged
importance: Undecided → High
assignee: nobody → yatin (yatinkarel)
milestone: none → ussuri-3
Revision history for this message
wes hayutin (weshayutin) wrote :

It does in fact look like --dev is introducing an error.
https://github.com/softwarefactory-project/DLRN/blob/db90a76a2c4ba744212eec92a605bf131d6d19a9/dlrn/build.py#L215-L233

So yes.. we should fix the bug! Thanks for your bug report!

# I do want to describe what is the current expected design for packages.
This design *does* create a problem if openstack client libraries are not
promoted to a version required for changes in python-tripleoclient for example.

The current design for tripleo upstream ci would be the following.

TripleO Packages:
  * these commits can be pulled in immediately after merge upstream.

  # name of delorean-tripleo-component-current? naming is hard
  - type: file
    reponame: delorean-current
    filename: delorean-current.repo
    down_url: "https://trunk.rdoproject.org/{{ distro_ver }}-{{ release }}/component/tripleo/current/delorean.repo"
    priority: 10
    includepkgs:
      - ansible-role-container-registry
      - ansible-role-tripleo*
      - ansible-tripleo-ipsec
      - instack
      - instack-undercloud
      - openstack-tripleo-*
      - os-apply-config
      - os-collect-config
      - os-net-config
      - os-refresh-config
      - puppet-*
      - python*-tripleo*
      - python*-paunch*
      - paunch-services
      - tripleo-ansible
      - ansible-config_template

Non-TripleO Packages should come from a validated set of rpms: ( current-tripleo )

https://trunk.rdoproject.org/centos8-master/current-tripleo/delorean.repo

wes hayutin (weshayutin)
tags: added: alert
Revision history for this message
Javier Peña (jpena-c) wrote :

https://review.opendev.org/717186 should give us the expected behavior.

Changed in tripleo:
status: Triaged → In Progress
wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-3 → ussuri-rc3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-quickstart-extras (master)

Change abandoned by wes hayutin (<email address hidden>) on branch: master
Review: https://review.opendev.org/717186
Reason: failing in the gate.. resetting this patch

Changed in tripleo:
assignee: yatin (yatinkarel) → wes hayutin (weshayutin)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by wes hayutin (<email address hidden>) on branch: master
Review: https://review.opendev.org/717186
Reason: failing in the gate.. yatin let's look at this together. Perhaps changes in tripleo repos are required

wes hayutin (weshayutin)
Changed in tripleo:
milestone: ussuri-rc3 → victoria-1
Changed in tripleo:
milestone: victoria-1 → victoria-3
Changed in tripleo:
milestone: victoria-3 → wallaby-1
Changed in tripleo:
milestone: wallaby-1 → wallaby-2
Changed in tripleo:
milestone: wallaby-2 → wallaby-3
Changed in tripleo:
milestone: wallaby-3 → wallaby-rc1
Changed in tripleo:
milestone: wallaby-rc1 → xena-1
Revision history for this message
Marios Andreou (marios-b) wrote :

This is an automated action. Bug status has been set to 'Incomplete' and target milestone has been removed due to inactivity. If you disagree please re-set these values and reach out to us on freenode #tripleo

Changed in tripleo:
milestone: xena-1 → none
status: In Progress → Incomplete
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by "yatin <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/tripleo-quickstart-extras/+/717186
Reason: abandoing for now, can be restored later if needed.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.