Undercloud update fails on generated playbook.

[Sofer Athlan-Guyot]

Hi,

originally reported there https://bugzilla.redhat.com/show_bug.cgi?id=1817457

Undercloud update fails with:

    2020-03-26 02:58:57 | Stack undercloud/c5bc28d0-b3cd-44c7-a885-871cf612b464 CREATE_COMPLETE
    2020-03-26 02:58:57 |
    2020-03-26 02:59:07 | Generating default ansible config file /home/stack/ansible.cfg
    2020-03-26 02:59:07 | ** Running ansible upgrade tasks **
    2020-03-26 02:59:08 | ERROR! no action detected in task. This often indicates a misspelled module name, or incorrect module path.
    2020-03-26 02:59:08 |
    2020-03-26 02:59:08 | The error appears to be in '/home/stack/undercloud-ansible-fgafm87l/common_deploy_steps_playbooks.yaml': line 47, column 7, but may
    2020-03-26 02:59:08 | be elsewhere in the file depending on the exact syntax problem.
    2020-03-26 02:59:08 |
    2020-03-26 02:59:08 | The offending line appears to be:
    2020-03-26 02:59:08 |
    2020-03-26 02:59:08 | tasks:
    2020-03-26 02:59:08 | - name: Render all_nodes data as group_vars for overcloud
    2020-03-26 02:59:08 | ^ here
    2020-03-26 02:59:08 | Exception: Upgrade failed
    2020-03-26 02:59:08 | Traceback (most recent call last):
    2020-03-26 02:59:08 | File "/usr/lib/python3.6/site-packages/tripleoclient/v1/tripleo_deploy.py", line 1319, in _standalone_deploy
    2020-03-26 02:59:08 | raise exceptions.DeploymentError('Upgrade failed')
    2020-03-26 02:59:08 | tripleoclient.exceptions.DeploymentError: Upgrade failed

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/716033

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/716034

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/717292

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/717719

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/717292
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0227a54473422a40815ca46b44068c73464ef8ca
Submitter: Zuul
Branch: master

commit 0227a54473422a40815ca46b44068c73464ef8ca
Author: Sofer Athlan-Guyot <email address hidden>
Date: Fri Apr 3 13:44:01 2020 +0200

    Update necessary packages before undercloud upgarde.

    This used to be a manual step in the tripleo process. You still have
    to update python-tripleoclient and tripleo-common manually. But:

     - "openstack-tripleo-heat-templates"
     - "openstack-tripleo-validations"
     - "tripleo-ansible"

    can all be installed from this process as we spawn another new process
    "openstack tripleo upgrade". Thus all those packages will be
    available for it.

    Note that tripleo-common should still be installed before running that
    command as some of its code is used by tripleoclient.

    Eventually adding version dependencies from python-tripleoclient to those
    other packages (or from tht which would stay a manual step) looks
    challenging as it would be hard to track which version work with which
    version.

    Change-Id: Ic258f314074007e7e5fd16d87448ffb7a3447fc3
    Closes-Bug: #1869776

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/718784

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 13.2.0 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/717719
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=42822ff9fc985a5e7b6be75b6f3911f3b0a89321
Submitter: Zuul
Branch: stable/train

commit 42822ff9fc985a5e7b6be75b6f3911f3b0a89321
Author: Sofer Athlan-Guyot <email address hidden>
Date: Fri Apr 3 13:44:01 2020 +0200

    Update necessary packages before undercloud upgarde.

    This used to be a manual step in the tripleo process. You still have
    to update python-tripleoclient and tripleo-common manually. But:

     - "openstack-tripleo-heat-templates"
     - "openstack-tripleo-validations"
     - "tripleo-ansible"

    can all be installed from this process as we spawn another new process
    "openstack tripleo upgrade". Thus all those packages will be
    available for it.

    Note that tripleo-common should still be installed before running that
    command as some of its code is used by tripleoclient.

    Eventually adding version dependencies from python-tripleoclient to those
    other packages (or from tht which would stay a manual step) looks
    challenging as it would be hard to track which version work with which
    version.

    Backport diff: we are using "yum" instead of "dnf" here because Train
    can run on CentOS 7 which uses yum, while CentOS 8 still has yum
    support. So don't add to much logic here and run everything with yum.

    Change-Id: Ic258f314074007e7e5fd16d87448ffb7a3447fc3
    Closes-Bug: #1869776
    (cherry picked from commit 0227a54473422a40815ca46b44068c73464ef8ca)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/718784
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=7d1b7389108ea22a68a2da17ff6bcf01ee99bd01
Submitter: Zuul
Branch: master

commit 7d1b7389108ea22a68a2da17ff6bcf01ee99bd01
Author: Alex Schultz <email address hidden>
Date: Thu Apr 9 13:46:36 2020 -0600

    Use undercloud upgrade to update all required pkgs

    Rather than require the end user to manually update packages prior to
    kicking off the undercloud process we can do it ourselves by
    implementing a flag to skip the update and invoking the upgrade after
    the packages have been updated.

    Change-Id: Idda6387922adeb182afd11cb0d692d1fcceff9a8
    Related-Bug: #1869776

[OpenStack Infra (hudson-openstack)]

Change abandoned by Athlan-Guyot sofer (<email address hidden>) on branch: master
Review: https://review.opendev.org/716033
Reason: This is not what we want see https://review.opendev.org/#/c/716034/ for a short description for this necessary evil to exist in train.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716034
Committed: https://git.openstack.org/cgit/openstack/tripleo-upgrade/commit/?id=b1032429fe11e86d41b364a3bb25f4f5153c4ec8
Submitter: Zuul
Branch: stable/train

commit b1032429fe11e86d41b364a3bb25f4f5153c4ec8
Author: Sofer Athlan-Guyot <email address hidden>
Date: Mon Mar 30 19:54:08 2020 +0200

    [TRAIN ONLY] Update tripleo-ansible before uc update/upgrade.

    Currently in the downstream product we enforce that rule with a
    documentation modification. But it's not the prefered way and
    shouldn't be the rule.

    So we make that *temporary* patch in train only until downstream
    catch up with the reviews[1][2] proposed which doens't involve user changing
    his procedure.

    [1] https://review.opendev.org/718683
    [2] https://review.opendev.org/717719

    Change-Id: I807d1c6dceb332480279a36f205b96bbea212024
    Related-Bug: #1869776

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/727886

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/727886
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=55c99266c9b589de93e3191cdd4d147e722fdf4a
Submitter: Zuul
Branch: stable/train

commit 55c99266c9b589de93e3191cdd4d147e722fdf4a
Author: Alex Schultz <email address hidden>
Date: Thu Apr 9 13:46:36 2020 -0600

    Use undercloud upgrade to update all required pkgs

    Rather than require the end user to manually update packages prior to
    kicking off the undercloud process we can do it ourselves by
    implementing a flag to skip the update and invoking the upgrade after
    the packages have been updated.

    Change-Id: Idda6387922adeb182afd11cb0d692d1fcceff9a8
    Related-Bug: #1869776
    (cherry picked from commit 7d1b7389108ea22a68a2da17ff6bcf01ee99bd01)

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/738662

[OpenStack Infra (hudson-openstack)]

Change abandoned by Sergii Golovatiuk (<email address hidden>) on branch: stable/stein
Review: https://review.opendev.org/738662

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.