THT generates hiera parameters for puppet-nova that are no longer used

[Alexey Stupnikov]

Since Train release several puppet classes were removed from puppet-nova [1]. At the same time, some of them are still used in tripleo heat templates

I have identified

- nova::use_ipv6
- nova::compute::neutron::libvirt_vif_driver

[1]
https://github.com/openstack/puppet-nova/blob/stable/train/releasenotes/notes/remove-nova-network-ac5d104fd47e3efc.yaml

[Alexey Stupnikov (astupnikov)]

Analysis:

- nova::use_ipv6 was used to configure IPv6 for nova-network. DEFAULT/use_ipv6 nova configuration option was deprecated in Ocata release and removed from puppet-nova in Train release. Setting this parameter in THT no longer changes anything
- nova::compute::neutron::libvirt_vif_driver seems like an artifact: though it was removed from puppet-nova only in Train release, actual nova configuration parameter was deprecated in IceHouse and hard-coded in Juno [1]

[1]
https://github.com/openstack/nova/blob/icehouse-eol/nova/virt/libvirt/driver.py#L187

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/715660

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715660
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ebfe7897af7923eaa42b8c60b27d90145e6823e9
Submitter: Zuul
Branch: master

commit ebfe7897af7923eaa42b8c60b27d90145e6823e9
Author: Alexey Stupnikov <email address hidden>
Date: Sat Mar 28 22:03:03 2020 +0100

    Remove Nova parameters that are no longer used

    Since Train release several puppet classes were removed
    from puppet-nova. At the same time, some of them are
    still defined in tripleo heat templates.

    - nova::use_ipv6 was used to configure IPv6 for nova-network.
      DEFAULT/use_ipv6 nova configuration option was deprecated
      in Ocata release and removed from puppet-nova in Train
      release. Setting this parameter in THT no longer affects
      anything.
    - nova::compute::neutron::libvirt_vif_driver seems like an
      artifact: though it was removed from puppet-nova only in
      Train release, actual nova configuration parameter was
      deprecated in IceHouse and hard-coded in Juno.

    Puppet-nova change id: I6f7fde1f475acec82bafc66183211f317b4c7795

    Change-Id: Ia269193f1f5215612165a2a0228bf4d1859b7b1e
    Closes-Bug: #1869528

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.2.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/761879

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/761879
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6b99abc5dbcd7def554b7a322a62307074aa3912
Submitter: Zuul
Branch: stable/train

commit 6b99abc5dbcd7def554b7a322a62307074aa3912
Author: Alexey Stupnikov <email address hidden>
Date: Sat Mar 28 22:03:03 2020 +0100

    Remove Nova parameters that are no longer used

    Since Train release several puppet classes were removed
    from puppet-nova. At the same time, some of them are
    still defined in tripleo heat templates.

    - nova::use_ipv6 was used to configure IPv6 for nova-network.
      DEFAULT/use_ipv6 nova configuration option was deprecated
      in Ocata release and removed from puppet-nova in Train
      release. Setting this parameter in THT no longer affects
      anything.
    - nova::compute::neutron::libvirt_vif_driver seems like an
      artifact: though it was removed from puppet-nova only in
      Train release, actual nova configuration parameter was
      deprecated in IceHouse and hard-coded in Juno.

    Puppet-nova change id: I6f7fde1f475acec82bafc66183211f317b4c7795

    Conflicts:
          deployment/nova/nova-base-puppet.yaml

    Resolved conflicts related to changes
    I42af3e39da76ae94ca7bbf2797f776c28a75f7e7 and
    If8a3d0a6db1b2950191ab62bdcfd7d2f12935de1
    both of these are changes are not required in stable/train release.

    Change-Id: Ia269193f1f5215612165a2a0228bf4d1859b7b1e
    Closes-Bug: #1869528
    (cherry picked from commit ebfe7897af7923eaa42b8c60b27d90145e6823e9)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.