Host entries for large scale deployments are stored in heat in a suboptimal fashion

Bug #1869375 reported by Bogdan Dobrelya
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Bogdan Dobrelya

Bug Description

When there are many nodes, networks and VIPs, the string-based representation of /etc/hosts entries for those become inefficient. It may be also limited by max string size, when being passed to ansible or bash scripts.

Those should be stored and processed as lists and also deduplicated.

Changed in tripleo:
importance: Undecided → Medium
milestone: none → ussuri-3
status: New → Triaged
assignee: nobody → Bogdan Dobrelya (bogdando)
tags: added: tech-debt
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/715431

Changed in tripleo:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/715178
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=3b8e6f78e19e776c087dc5c3ff225703b5c487bc
Submitter: Zuul
Branch: master

commit 3b8e6f78e19e776c087dc5c3ff225703b5c487bc
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Mar 26 12:26:53 2020 +0100

    Use lists for storing host entries in Heat

    This simplifies all the split/join transformations and improves the
    memory footprint to a reduced list of unique entries for
    HostsEntryValue (originally required for storing the ultimate data for
    hosts entries in a form of a quite long single-line string value).

    That improves the hosts entries processing for large scale deployments
    and removes possible limitations to the sizes of strings.

    Closes-bug: #1869375
    Change-Id: I5ac498621e9e3c49def565744a7b521cb2cc5c25
    Signed-off-by: Bogdan Dobrelya <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Bogdan Dobrelya (bogdando) (<email address hidden>) on branch: master
Review: https://review.opendev.org/715431
Reason: https://review.opendev.org/#/c/716236

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/716497

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/716497
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=ba719349509727a29dc780857948393bce11aba1
Submitter: Zuul
Branch: stable/train

commit ba719349509727a29dc780857948393bce11aba1
Author: Bogdan Dobrelya <email address hidden>
Date: Thu Mar 26 12:26:53 2020 +0100

    Use lists for storing host entries in Heat

    This simplifies all the split/join transformations and improves the
    memory footprint to a reduced list of unique entries for
    HostsEntryValue (originally required for storing the ultimate data for
    hosts entries in a form of a quite long single-line string value).

    That improves the hosts entries processing for large scale deployments
    and removes possible limitations to the sizes of strings.

    Closes-bug: #1869375
    Change-Id: I5ac498621e9e3c49def565744a7b521cb2cc5c25
    Signed-off-by: Bogdan Dobrelya <email address hidden>
    (cherry picked from commit 3b8e6f78e19e776c087dc5c3ff225703b5c487bc)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 12.2.0

This issue was fixed in the openstack/tripleo-heat-templates 12.2.0 release.

Revision history for this message
Emilien Macchi (emilienm) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.