Weak string comparaison leads to a deploy failure if hostname is CaMeLcAsEd

[Cédric Jeanneret]

This was discussed on Red Hat Bugzilla:
https://bugzilla.redhat.com/show_bug.cgi?id=1816481

In short:
some weak string comparisons in tripleo-heat-templates content led to some tasks being filtered out, and not executed.

Those tasks are all the *_init_tasks - meaning we reach step 3 without any service configuration, and we fail to inject DB content (since mariadb has no user).

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/715408

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/715409

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/715412

[OpenStack Infra (hudson-openstack)]

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.opendev.org/715408
Reason: https://review.opendev.org/#/c/715412/1

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715409
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=e236ff0cf97d370dcad74467caa2d88d133dc6c1
Submitter: Zuul
Branch: master

commit e236ff0cf97d370dcad74467caa2d88d133dc6c1
Author: Cédric Jeanneret <email address hidden>
Date: Fri Mar 27 11:35:50 2020 +0100

    Ensure consistency with hostname comparison

    It might happen an operator wants to get «camelcased» hostname.

    Since the RFC[1] states "no distinction is made between upper and lower
    case", we have to ensure string comparisons made in ansible are all
    lowered.

    [1] https://tools.ietf.org/html/rfc952

    Closes-Bug: #1869360
    Needed-By: https://review.opendev.org/71541
    Change-Id: I988a8ce958f9fb21115aacde526c2dc89a3c8d66

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/715412
Committed: https://git.openstack.org/cgit/openstack/tripleo-quickstart/commit/?id=1ab28553c590d57df0444e57a8e57a8ac0d2400b
Submitter: Zuul
Branch: master

commit 1ab28553c590d57df0444e57a8e57a8ac0d2400b
Author: Cédric Jeanneret <email address hidden>
Date: Fri Mar 27 13:21:04 2020 +0100

    Deploy fs027 with CaMelCased hostname

    This should help prevent regressions.

    Change-Id: I1074e0204910726d82950496ac4813a06e315252
    Depends-On: https://review.opendev.org/715409
    Related-Bug: #1869360

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/716166

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/716166
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=59f34c3af572e9bc1420661df9e71bfd6df0de8e
Submitter: Zuul
Branch: stable/train

commit 59f34c3af572e9bc1420661df9e71bfd6df0de8e
Author: Cédric Jeanneret <email address hidden>
Date: Fri Mar 27 11:35:50 2020 +0100

    Ensure consistency with hostname comparison

    It might happen an operator wants to get «camelcased» hostname.

    Since the RFC[1] states "no distinction is made between upper and lower
    case", we have to ensure string comparisons made in ansible are all
    lowered.

    [1] https://tools.ietf.org/html/rfc952

    Closes-Bug: #1869360
    Change-Id: I988a8ce958f9fb21115aacde526c2dc89a3c8d66
    (cherry picked from commit e236ff0cf97d370dcad74467caa2d88d133dc6c1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 12.2.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.