The 'undercloud-passwords.conf' path is not consistently returned

Bug #1868619 reported by Kevin Carter
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
High
Kevin Carter

Bug Description

When running tripleoclient commands, the output path for the file 'undercloud-passwords.conf' is not consistently returned; the file is assumed to be using the configured `output_dir` though within the client the output information may report the file is within `~/`. To correct this cosmetic issue we need to normalize our return information.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.opendev.org/714527

Changed in tripleo:
assignee: nobody → Kevin Carter (kevin-carter)
status: New → In Progress
Changed in tripleo:
milestone: none → ussuri-3
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/714529

tags: added: train-backport-potential
tags: added: stein-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/714527
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=8dc3273495c13924861fd4fca103732f0d48fc2d
Submitter: Zuul
Branch: master

commit 8dc3273495c13924861fd4fca103732f0d48fc2d
Author: Kevin Carter <email address hidden>
Date: Mon Mar 23 15:33:26 2020 -0500

    Normalize the 'undercloud-passwords.conf' return data

    This change normalizes our client return formation by ensuring we're always
    using the configured output path as defined within our constants.

    Closes-Bug: #1868619

    Change-Id: Ied051214c4d3f2a695d58a6cde6180f040ca02d4
    Signed-off-by: Kevin Carter <email address hidden>

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to python-tripleoclient (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/716281

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/716281
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=8f5a2dab0717c646b2925f112762febb717d16cf
Submitter: Zuul
Branch: stable/train

commit 8f5a2dab0717c646b2925f112762febb717d16cf
Author: Kevin Carter <email address hidden>
Date: Mon Mar 23 15:33:26 2020 -0500

    Normalize the 'undercloud-passwords.conf' return data

    This change normalizes our client return formation by ensuring we're always
    using the configured output path as defined within our constants.

    Closes-Bug: #1868619

    Change-Id: Ied051214c4d3f2a695d58a6cde6180f040ca02d4
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit 8dc3273495c13924861fd4fca103732f0d48fc2d)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (master)

Reviewed: https://review.opendev.org/714529
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d38c7c329f16e1b9fcc415843639a6b8f4a19f06
Submitter: Zuul
Branch: master

commit d38c7c329f16e1b9fcc415843639a6b8f4a19f06
Author: Kevin Carter <email address hidden>
Date: Mon Mar 23 16:06:38 2020 -0500

    Ensure the undercloud output dir constant is consistent

    By default the output directory is the executing users home folder,
    however, because this is meant to be user configurable, we need
    to modify our constants to respect the users configured information.

    This change ensures that the constant UNDERCLOUD_OUTPUT_DIR is consistently
    by pre-loading the undercloud configration file when present and pulling
    out the `output_dir` option. When this file is not present or the option
    is undefined, the constant will use the executing users home folder; the
    execting users home folder is the original default.

    Related-Bug: #1868619

    Change-Id: I94257d1d5ceb2795f5d9596a6a1d5066d881c3b7
    Signed-off-by: Kevin Carter <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-tripleoclient (stable/train)

Related fix proposed to branch: stable/train
Review: https://review.opendev.org/718415

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-tripleoclient (stable/train)

Reviewed: https://review.opendev.org/718415
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=d4c35c062d6a50bb15d584a543b24dfd4eda8188
Submitter: Zuul
Branch: stable/train

commit d4c35c062d6a50bb15d584a543b24dfd4eda8188
Author: Kevin Carter <email address hidden>
Date: Mon Mar 23 16:06:38 2020 -0500

    Ensure the undercloud output dir constant is consistent

    By default the output directory is the executing users home folder,
    however, because this is meant to be user configurable, we need
    to modify our constants to respect the users configured information.

    This change ensures that the constant UNDERCLOUD_OUTPUT_DIR is consistently
    by pre-loading the undercloud configration file when present and pulling
    out the `output_dir` option. When this file is not present or the option
    is undefined, the constant will use the executing users home folder; the
    execting users home folder is the original default.

    Related-Bug: #1868619

    Change-Id: I94257d1d5ceb2795f5d9596a6a1d5066d881c3b7
    Signed-off-by: Kevin Carter <email address hidden>
    (cherry picked from commit d38c7c329f16e1b9fcc415843639a6b8f4a19f06)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 13.2.0

This issue was fixed in the openstack/python-tripleoclient 13.2.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-tripleoclient 12.4.0

This issue was fixed in the openstack/python-tripleoclient 12.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.