Prevent creation of unnecessary Ceph variables

Bug #1867006 reported by Francesco Pantano
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Undecided
Francesco Pantano

Bug Description

When the overcloud is deployed with ceph, even though the RGW is not deployed the config contains a lot of rgw related (and unused) variables [1].
We should move these variables in the related services, adding them only when the service is deployed.

[1] https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ceph-ansible/ceph-base.yaml#L402

Changed in tripleo:
assignee: nobody → Francesco Pantano (fmount)
tags: added: train-backport-potential
Changed in tripleo:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Francesco Pantano (<email address hidden>) on branch: master
Review: https://review.opendev.org/705442

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (master)

Reviewed: https://review.opendev.org/711942
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=c5ecafbddc9e06df657523c1fc3b19f8c2860f75
Submitter: Zuul
Branch: master

commit c5ecafbddc9e06df657523c1fc3b19f8c2860f75
Author: Francesco Pantano <email address hidden>
Date: Mon Mar 9 16:51:22 2020 +0100

    Add ceph config overrides support

    This change adds ceph config overrides support by
    moving the logic from tht to tripleo-ansible.
    This allow us to avoid centralizing all the
    variables in ceph-base.yml, distributing them to
    the related templates.
    The logic implemented here just merge the provided
    structures, maintaining backward compatibility with
    the old used "key:value" pattern without a specific
    section (which use global by default).

    Closes-Bug: #1867006
    Change-Id: Idbe0a6526fa262121bbb424f8705a3664ea00abd

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/705442
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=0a8c5697df019ceedd5c79d0f3c563a0db846406
Submitter: Zuul
Branch: master

commit 0a8c5697df019ceedd5c79d0f3c563a0db846406
Author: Francesco Pantano <email address hidden>
Date: Mon Feb 3 14:18:30 2020 +0100

    Move ceph-rgw and config overrides variables

    If no CephRgw service is present there's no reason to have all the
    rgw related variables generated.
    This change moves the rgw variables to ceph-rgw.yml which will be
    added when the service is deployed.

    Closes-Bug: #1867006
    Depends-On: https://review.opendev.org/711942
    Change-Id: I6302cbd971ee0f82b21630f3a0f56a9ca9a18658

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-ansible (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/719947

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/719948

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-ansible (stable/train)

Reviewed: https://review.opendev.org/719947
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=131588559a77d37b6812cf6a05bb980e3da858df
Submitter: Zuul
Branch: stable/train

commit 131588559a77d37b6812cf6a05bb980e3da858df
Author: Francesco Pantano <email address hidden>
Date: Mon Mar 9 16:51:22 2020 +0100

    Add ceph config overrides support

    This change adds ceph config overrides support by
    moving the logic from tht to tripleo-ansible.
    This allow us to avoid centralizing all the
    variables in ceph-base.yml, distributing them to
    the related templates.
    The logic implemented here just merge the provided
    structures, maintaining backward compatibility with
    the old used "key:value" pattern without a specific
    section (which use global by default).

    Closes-Bug: #1867006
    Change-Id: Idbe0a6526fa262121bbb424f8705a3664ea00abd
    (cherry picked from commit c5ecafbddc9e06df657523c1fc3b19f8c2860f75)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/train)

Reviewed: https://review.opendev.org/719948
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=d570a95c408291e95f9b385d90b750d86a7e0e86
Submitter: Zuul
Branch: stable/train

commit d570a95c408291e95f9b385d90b750d86a7e0e86
Author: Francesco Pantano <email address hidden>
Date: Mon Feb 3 14:18:30 2020 +0100

    Move ceph-rgw and config overrides variables

    If no CephRgw service is present there's no reason to have all the
    rgw related variables generated.
    This change moves the rgw variables to ceph-rgw.yml which will be
    added when the service is deployed.

    Closes-Bug: #1867006
    Depends-On: https://review.opendev.org/#/c/719947
    Change-Id: I6302cbd971ee0f82b21630f3a0f56a9ca9a18658
    (cherry picked from commit 0a8c5697df019ceedd5c79d0f3c563a0db846406)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-ansible 0.6.0

This issue was fixed in the openstack/tripleo-ansible 0.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.4.0

This issue was fixed in the openstack/tripleo-heat-templates 11.4.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.