Duplicate declaration: Package[collectd-python] is already declared at puppet-collectd and puppet-tripleo

[chandan kumar]

CentOS-8 standalone scenario 1 distgit job got failed
https://logserver.rdoproject.org/12/25612/16/check/distgit-tripleo-master-testing-centos-8-standalone-scenario001/9b5f4e3/logs/undercloud/var/log/containers/stdouts/container-puppet-collectd.log.txt.gz

2020-03-11T06:14:29.071695149+00:00 stdout F include ::tripleo::packages
2020-03-11T06:14:29.071695149+00:00 stdout F include ::tripleo::profile::base::metrics::collectd
2020-03-11T06:14:29.130185738+00:00 stdout F Running puppet
2020-03-11T06:14:29.130234939+00:00 stderr F + logger -s -t puppet-user
2020-03-11T06:14:29.130234939+00:00 stderr F + /usr/bin/puppet apply --summarize --detailed-exitcodes --color=false --modulepath=/etc/puppet/modules:/usr/share/openstack-puppet/modules --tags '"file,file_line,concat,augeas,cron,collectd_client_config,exec"' /etc/config.pp
2020-03-11T06:14:35.054971944+00:00 stderr F <13>Mar 11 06:14:29 puppet-user: Warning: /etc/puppet/hiera.yaml: Use of 'hiera.yaml' version 3 is deprecated. It should be converted to version 5
2020-03-11T06:14:35.054971944+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: (file: /etc/puppet/hiera.yaml)
2020-03-11T06:14:35.054971944+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: Warning: Undefined variable '::deploy_config_name'; \n (file & line not available)
2020-03-11T06:14:35.067305857+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: Warning: ModuleLoader: module 'tripleo' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\n (file & line not available)
2020-03-11T06:14:35.109460780+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: Warning: The function 'hiera' is deprecated in favor of using 'lookup'. See https://puppet.com/docs/puppet/5.5/deprecated_language.html\n (file & line not available)
2020-03-11T06:14:35.121233030+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: Warning: ModuleLoader: module 'collectd' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\n (file & line not available)
2020-03-11T06:14:35.172652294+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: Warning: ModuleLoader: module 'concat' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules\n (file & line not available)
2020-03-11T06:14:35.258087150+00:00 stderr F <13>Mar 11 06:14:35 puppet-user: Error: Evaluation Error: Error while evaluating a Resource Statement, Duplicate declaration: Package[collectd-python] is already declared at (file: /etc/puppet/modules/collectd/manifests/plugin/python.pp, line: 38); cannot redeclare (file: /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd.pp, line: 285) (file: /etc/puppet/modules/tripleo/manifests/profile/base/metrics/collectd.pp, line: 285, column: 5) on node standalone.localdomain
2020-03-11T06:14:35.269831569+00:00 stderr F + rc=1
2020-03-11T06:14:35.269831569+00:00 stderr F + '[' false = false ']'
2020-03-11T06:14:35.269831569+00:00 stderr F + set +x

By checking the puppet-collectd code, recently they have added centos-8 support https://github.com/voxpupuli/puppet-collectd/commit/672452018abefde44f18de9cb75a3102e0745f61

It might broke it. We need to remove the https://github.com/openstack/puppet-tripleo/blob/master/manifests/profile/base/metrics/collectd.pp#L284 to fix the issue.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/712289

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/712289
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=3e8e98dde34a42894f075ad27a34957a7c76b116
Submitter: Zuul
Branch: master

commit 3e8e98dde34a42894f075ad27a34957a7c76b116
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Wed Mar 11 14:39:01 2020 +0530

    Remove duplicate entry of collectd-python package

    https://github.com/voxpupuli/puppet-collectd/commit/672452018abefde44f18de9cb75a3102e0745f61
    in puppet-collectd adds supports of CentOS-8 and collect-python
    package is already defined there.

    In puppet-tripleo, it started complaining about duplicate entry of
    collectd-python package, removing the same fixes for puppet-tripleo
    fixes the issue.

    Closes-Bug: #1866965

    Change-Id: If1a2c65c4208c2255a3140134204e240496ec8b6
    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 12.2.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/725852

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/725852
Committed: https://git.openstack.org/cgit/openstack/puppet-tripleo/commit/?id=4cefed3c01311a79079434e74150db838d7a9950
Submitter: Zuul
Branch: stable/train

commit 4cefed3c01311a79079434e74150db838d7a9950
Author: Chandan Kumar (raukadah) <email address hidden>
Date: Wed Mar 11 14:39:01 2020 +0530

    Remove duplicate entry of collectd-python package

    https://github.com/voxpupuli/puppet-collectd/commit/672452018abefde44f18de9cb75a3102e0745f61
    in puppet-collectd adds supports of CentOS-8 and collect-python
    package is already defined there.

    In puppet-tripleo, it started complaining about duplicate entry of
    collectd-python package, removing the same fixes for puppet-tripleo
    fixes the issue.

    Closes-Bug: #1866965

    Change-Id: If1a2c65c4208c2255a3140134204e240496ec8b6
    Signed-off-by: Chandan Kumar (raukadah) <email address hidden>
    (cherry picked from commit 3e8e98dde34a42894f075ad27a34957a7c76b116)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/puppet-tripleo 11.5.0 release.