overcloud node introspect --all-manageable no longer fail if no manageble nodes

[Harald Jensås]

Prior to moving to ansible the workflow to introspect all manageable ironic nodes used to fail if no nodes where in manageable state.

(undercloud) [cloud-user@undercloud ~]$ openstack overcloud node introspect --all-manageable
Waiting for introspection to finish...
Waiting for messages on queue 'tripleo' with no timeout.
No manageable nodes to introspect. Check node states and maintenance.
Exception introspecting nodes: No manageable nodes to introspect. Check node states and maintenance.
(undercloud) [cloud-user@undercloud ~]$ echo $?
1

The ansible playbook simply put's a notice on the console:
https://opendev.org/openstack/tripleo-ansible/src/branch/master/tripleo_ansible/playbooks/cli-baremetal-introspect.yaml#L74-L83

See end of log: https://logserver.rdoproject.org/36/711436/1/openstack-check/tripleo-ci-centos-7-ovb-3ctlr_1comp-featureset001/aeae9c5/logs/undercloud/home/zuul/overcloud_prep_images.log.txt.gz

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/712203

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/712203
Committed: https://git.openstack.org/cgit/openstack/tripleo-ansible/commit/?id=e10d6f4fe66447fcbf960f460cdba0c9304f3e34
Submitter: Zuul
Branch: master

commit e10d6f4fe66447fcbf960f460cdba0c9304f3e34
Author: Steve Baker <email address hidden>
Date: Tue Mar 10 22:31:09 2020 +0000

    Fail when there are no nodes to introspect

    The mistral workflow would fail when no nodes were in a manageable
    state to introspect. This change replicates that behaviour.

    One of the causes of bug #1866204 is that there is a reliance on the
    time it takes to to the introspect for the node segment mappings to
    populate. When introspect finishes instantly, provide ends up timing
    out because the port create fails.

    Change-Id: I8a27a098b3cd006f73c33d95f2d93c65cf629203
    Closes-Bug: #1866911
    Related-Bug: #1866204

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/tripleo-ansible 1.3.0 release.