deployment variable leaked outside of loop scope
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
tripleo |
Fix Released
|
Undecided
|
Kevin Carter |
Bug Description
when running a deployment it is possible for a the deployment to fail due to the "payload" object not being defined. This is caused by a leaked variable being used outside of the loop scope. While this works today due to the assumption of an executed workflow, if there were no workflows called the variable would be undefined resulting in the following stacktrace:
Captured traceback:
~~~~~~~~~~~~~~~~~~~
Traceback (most recent call last):
File "/home/
return func(*args, **keywargs)
File "/home/
File "/home/
File "/home/
File "/home/
File "/home/
File "/home/
File "/home/
deploy(log, clients, **workflow_input)
File "/home/
if payload['status'] != "SUCCESS":
UnboundLoca
To correct this issue the leaked variable should be moved inside the loop.
Changed in tripleo: | |
assignee: | nobody → Kevin Carter (kevin-carter) |
status: | New → In Progress |
Reviewed: https:/ /review. opendev. org/709583 /git.openstack. org/cgit/ openstack/ python- tripleoclient/ commit/ ?id=ad9c7a7504e dd3da36365e267e f38c037241d6f9
Committed: https:/
Submitter: Zuul
Branch: master
commit ad9c7a7504edd3d a36365e267ef38c 037241d6f9
Author: Kevin Carter <email address hidden>
Date: Mon Feb 24 12:28:58 2020 -0600
Remove mistral when running the register_or_update workflow
This change removes all of mistral from the register_or_update workflow
by calling the required functions directly.
Story: 2007212
Task: 38442
Closes-Bug: #1866637 c469d6979a424d8 f01b00f34f2
Change-Id: Ie85adc64cd4fce
Signed-off-by: Kevin Carter <email address hidden>